Fix compile error under newer toolchain and arrow 10 #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighingnow
approved these changes
Dec 27, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2355 +/- ##
=======================================
Coverage 43.59% 43.59%
=======================================
Files 88 88
Lines 9714 9714
=======================================
Hits 4235 4235
Misses 5479 5479 Continue to review full report at Codecov.
|
sighingnow
reviewed
Dec 28, 2022
| include(CheckCXXCompilerFlag) | ||
| CHECK_CXX_COMPILER_FLAG("-std=c++17" HAS_STDCXX_17) | ||
| if (HAS_STDCXX_17) | ||
| set(CMAKE_CXX_STANDARD 14) |
There was a problem hiding this comment.
Should be set(CMAKE_CXX_STANDARD 17) in if branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several build failures