Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing header files #2360

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Conversation

songqing
Copy link
Contributor

What do these changes do?

When building my test, I encounter some compile errors as some header files are missed, besides, namespace is not assigned in some macro definitions.

Related issue number

Fixes

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Merging #2360 (7348d5b) into main (b80a355) will increase coverage by 3.55%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
+ Coverage   40.03%   43.59%   +3.55%     
==========================================
  Files          88       88              
  Lines        9713     9714       +1     
==========================================
+ Hits         3889     4235     +346     
+ Misses       5824     5479     -345     
Impacted Files Coverage Δ
python/graphscope/deploy/kubernetes/utils.py 64.53% <0.00%> (-0.32%) ⬇️
python/graphscope/framework/dag_utils.py 44.37% <0.00%> (+0.33%) ⬆️
python/graphscope/framework/graph_utils.py 70.23% <0.00%> (+2.77%) ⬆️
python/graphscope/client/session.py 68.18% <0.00%> (+3.03%) ⬆️
python/graphscope/analytical/udf/utils.py 39.36% <0.00%> (+3.19%) ⬆️
python/graphscope/tests/conftest.py 52.44% <0.00%> (+4.23%) ⬆️
python/graphscope/framework/graph_schema.py 59.36% <0.00%> (+6.62%) ⬆️
python/graphscope/client/rpc.py 80.59% <0.00%> (+6.71%) ⬆️
python/graphscope/framework/app.py 80.18% <0.00%> (+9.67%) ⬆️
python/graphscope/framework/utils.py 57.84% <0.00%> (+14.46%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80a355...7348d5b. Read the comment docs.

@sighingnow sighingnow merged commit c3b5e93 into alibaba:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants