Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flatten fragment over a fragment with masked labels #2477

Merged
merged 5 commits into from Mar 7, 2023

Conversation

sighingnow
Copy link
Collaborator

@sighingnow sighingnow commented Mar 1, 2023

What do these changes do?

  • Fixes bugs in flatten fragment
  • Upgrade GAE to latest vineyard

Related issue number

Fixes #2476

See also:

@sighingnow sighingnow force-pushed the ht/fix-project-masked branch 2 times, most recently from 8b78374 to 8996cbd Compare March 1, 2023 13:47
Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@@ -36,22 +36,21 @@ jobs:
- uses: actions/checkout@v3

- name: Install latest vineyard
if: false
if: true
run: |
git clone --single-branch --depth=1 https://github.com/v6d-io/v6d.git /tmp/v6d
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git clone --single-branch --depth=1 https://github.com/v6d-io/v6d.git /tmp/v6d
source ~/.graphscope_env
git clone --single-branch --depth=1 https://github.com/v6d-io/v6d.git /tmp/v6d

@sighingnow sighingnow force-pushed the ht/fix-project-masked branch 2 times, most recently from b1458c2 to 46878d1 Compare March 2, 2023 07:13
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #2477 (f9c8e45) into main (d6bde76) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2477      +/-   ##
==========================================
+ Coverage   72.48%   72.62%   +0.14%     
==========================================
  Files          88       88              
  Lines        9769     9809      +40     
==========================================
+ Hits         7081     7124      +43     
+ Misses       2688     2685       -3     
Impacted Files Coverage Δ
python/graphscope/config.py 100.00% <100.00%> (ø)
python/graphscope/tests/unittest/test_app.py 96.62% <100.00%> (+0.31%) ⬆️
python/graphscope/tests/unittest/test_graph.py 86.24% <100.00%> (+0.33%) ⬆️
...hon/graphscope/tests/unittest/test_create_graph.py 92.88% <0.00%> (ø)
python/graphscope/framework/app.py 90.41% <0.00%> (+0.08%) ⬆️
python/graphscope/tests/conftest.py 87.04% <0.00%> (+0.65%) ⬆️
python/graphscope/analytical/app/pagerank.py 100.00% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6bde76...f9c8e45. Read the comment docs.

@sighingnow sighingnow force-pushed the ht/fix-project-masked branch 2 times, most recently from 91b20f4 to 7c2b940 Compare March 7, 2023 01:09
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Flatten on projected fragment yields incorrected result in GAE
3 participants