Enable running multiple GIE instances on a same vineyardd server #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuan0322
approved these changes
Mar 13, 2023
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
sighingnow
force-pushed
the
ht/multiple-gie-one-vineyard
branch
from
80234da
to
ca9f51d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
We will decouple the deploy of vineyard and graphscope (see also #2458) where vineyard and graphscope workers may not aligned. After that, on one kubernetes node, there might be only 1 vineyardd instance and more than one graphscope workers (specially GIE executors) on it.
Before this pull request, that workable, but yields wrong (duplication) query results. This pull fixed that by first sync process partition list and splitted the partitions to "local" work processes.
To avoid disturbe existing users, the new feature is only availbel when the environment variable
PARALLEL_INTERACTIVE_EXECUTOR_ON_VINEYARDis set toOFF(bothONandOFFare covered by CI).Related issue number
N/A