[GIE/Doc] Add initial design docs of GIE #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longbinlai
changed the title
yecol
reviewed
Mar 14, 2023
docs/design_of_gie.md
Outdated
|
|
||
| <img src="images/design_of_gie.png" | ||
| alt="The architecture of GIE" | ||
| style="border-radius: 0.3125em; box-shadow: 0 2px 4px 0 rgba(34,36,38,.12),0 2px 10px 0 rgba(34,36,38,.08);" |
There was a problem hiding this comment.
Just a suggestion: to make it consistent and concise, maybe remove the style to make figures flat and borderless.
There was a problem hiding this comment.
Okay. I refine the other images as well.
yecol
reviewed
Mar 14, 2023
yecol
approved these changes
Mar 14, 2023
We could add a global style configuration for images, titles, etc. after finalize the documentation itself. |
|
🎊 PR Preview 8213f36 has been successfully built and deployed to https://alibaba-graphscope-build-pr-2518.surge.sh 
🤖 By surge-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to add the first design docs of GIE, including the design of IR layer, and the Codegen for different computing engines, etc.