Add a CI step to avoid running the tmate session on the self-hosted machine #2529
Conversation
dashanji
force-pushed
the
avoid-tmate-operation
branch
4 times, most recently
from
a5aca7a
to
52594a3
Compare
|
Wait for testing here. |
.github/workflows/gaia.yml
Outdated
| @@ -23,6 +23,12 @@ jobs: | |||
| gaia-test: | |||
| runs-on: [self-hosted, manylinux2014] | |||
| steps: | |||
| - name: Detect the tmate session | |||
| if: "jobs.gaia-test.steps[*].uses == 'mxschmitt/action-tmate@*'" | |||
There was a problem hiding this comment.
could we use '*/action-tmate'?
Since mxschmitt is not the only one that provides action-tmate.
There was a problem hiding this comment.
Make sense to me.
dashanji
force-pushed
the
avoid-tmate-operation
branch
2 times, most recently
from
1b50d66
to
68e1730
Compare
|
From the github steps context, we can't get the info of steps that wait for running. So use a static code check here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
=======================================
Coverage 39.88% 39.88%
=======================================
Files 88 88
Lines 9814 9814
=======================================
Hits 3914 3914
Misses 5900 5900 Continue to review full report in Codecov by Sentry.
|
.github/workflows/pegasus.yml
Outdated
| @@ -50,6 +50,12 @@ jobs: | |||
| k8s-test: | |||
| runs-on: [self-hosted, ubuntu2004] | |||
| steps: | |||
| - name: Detect the tmate session | |||
| if: "jobs.k8s-test.steps[*].uses == 'mxschmitt/action-tmate@*'" | |||
There was a problem hiding this comment.
why this is still use the context while others use grep
There was a problem hiding this comment.
My bad. Thanks for catching this.
dashanji
force-pushed
the
avoid-tmate-operation
branch
from
68e1730
to
32a0fb9
Compare
…achine. Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
dashanji
force-pushed
the
avoid-tmate-operation
branch
from
32a0fb9
to
fe81454
Compare
Addressed. |
What do these changes do?
As titled.
Related issue number
Fix #2528.