Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIE Standalone] Add helm chart to deploy GIE on vineyard storage #2546

Merged
merged 46 commits into from Mar 28, 2023

Conversation

shirly121
Copy link
Collaborator

What do these changes do?

as titled

Fixes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

🎊 PR Preview 9cded77 has been successfully built and deployed to https://alibaba-graphscope-build-pr-2546.surge.sh

🤖 By surge-preview

@shirly121 shirly121 added the wip label Mar 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #2546 (512824e) into main (0ceacd1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2546   +/-   ##
=======================================
  Coverage   39.90%   39.90%           
=======================================
  Files          88       88           
  Lines        9838     9838           
=======================================
  Hits         3926     3926           
  Misses       5912     5912           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c3a1a3...512824e. Read the comment docs.

kubectl describe svc <your-release-name>-gie-standalone-frontend | grep "Endpoints:" | awk -F' ' '{print $2}'
```
## Customized Config
### download helm package
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm support configuring from command line or from a file.
https://helm.sh/zh/docs/helm/helm_install/
It's the recommended way to customize configurations over download the source codes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm support configuring from command line or from a file. https://helm.sh/zh/docs/helm/helm_install/ It's the recommended way to customize configurations over download the source codes.

嗯,我的文档没写清楚,需要从source code配置的应该是自定义的loader文件,这个我看官方helm是需要在指定目录下添加文件,最终才能被load进configMap

@shirly121 shirly121 removed the wip label Mar 28, 2023
@longbinlai longbinlai added component:doc Improvements or additions to documentation component:gie labels Mar 28, 2023
@longbinlai longbinlai added this to In progress in GIE v2.0 via automation Mar 28, 2023
Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

### etcd
```
# TODO: the link need to be updated after merging to main
kubectl apply -f https://raw.githubusercontent.com/shirly121/GraphScope/add_gie_deploy/charts/gie-standalone/tools/etcd.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to have kubectl apply -f https://raw.githubusercontent.com/alibaba/GraphScope/add_gie_deploy/charts/gie-standalone/tools/etcd.yaml before merging.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just for my reference to write gie docs. Cheers

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longbinlai longbinlai merged commit b1c9f42 into alibaba:main Mar 28, 2023
39 checks passed
GIE v2.0 automation moved this from In progress to Done Mar 28, 2023
@longbinlai longbinlai linked an issue Apr 10, 2023 that may be closed by this pull request
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:doc Improvements or additions to documentation component:gie
Projects
Development

Successfully merging this pull request may close these issues.

Documentation enhancement
5 participants