Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the doc about how to deploy graphscope on existing vineyard cluster #2555

Merged
merged 1 commit into from Apr 4, 2023
Merged

Add the doc about how to deploy graphscope on existing vineyard cluster #2555

merged 1 commit into from Apr 4, 2023

Conversation

dashanji
Copy link
Collaborator

What do these changes do?

As titled.

The doc is based on the latest main branch, but it doesn't release now. So if users follow the doc with the latest release, some errors will encounter as the k8s_deployment parameter is not present. Is it possible to move the doc to the next version?

Related issue number

Fixes #2549

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023 •
edited

🎊 PR Preview 044f154 has been successfully built and deployed to https://alibaba-graphscope-build-pr-2555.surge.sh

🤖 By surge-preview

@dashanji dashanji requested review from yecol, siyuan0322 and sighingnow and removed request for yecol March 24, 2023 02:35
sighingnow
sighingnow reviewed Mar 24, 2023
View reviewed changes
docs/deployment/deploy_graphscope_on_existing_vineyard_cluster.md Outdated
$ kubectl get nodes -A
NAME STATUS ROLES AGE VERSION
gs Ready control-plane 18s v1.24.1
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just refer to docs/deployment/deploy_graphscope_on_self_managed_k8s.md for the Kubernetes preparation and don't repeat the same instructions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

@yecol
Copy link
Collaborator

yecol commented Mar 24, 2023

Hi @dashanji , do not worry about your concern. Users visit URL at graphscope.io/docs by default, which is a stable (and stall) version for the current release; Merged docs PR will be generated and updated under the tag latest.

@dashanji
Copy link
Collaborator Author

Hi @dashanji , do not worry about your concern. Users visit URL at graphscope.io/docs by default, which is a stable (and stall) version for the current release; Merged docs PR will be generated and updated under the tag latest.

Make sense to me. Thanks!

@dashanji
Add the doc about how to deploy graphscope on the existing vineyard c…
044f154 
…luster

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji dashanji force-pushed the add-vineyard-deployment-doc branch from e0ce197 to 044f154 Compare April 4, 2023 07:28
@siyuan0322 siyuan0322 merged commit 6bd4a81 into alibaba:main Apr 4, 2023
21 checks passed
@dashanji dashanji deleted the add-vineyard-deployment-doc branch April 4, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighingnow sighingnow sighingnow approved these changes

@siyuan0322 siyuan0322 siyuan0322 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc] Add a doc about how to use GraphScope with an existing vineyard cluster
4 participants
@dashanji @yecol @sighingnow @siyuan0322