[GAE/WCC] Fix WCC' implementation on undirected graph #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
===========================================
+ Coverage 39.90% 72.58% +32.67%
===========================================
Files 88 88
Lines 9838 9838
===========================================
+ Hits 3926 7141 +3215
+ Misses 5912 2697 -3215 see 47 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
sighingnow
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
LGTM. But we still keep to keep the compatibility check in Python, as it actually use the version defined the libgrape-lite: https://github.com/alibaba/libgrape-lite/blob/master/examples/analytical_apps/wcc/wcc.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
There are multiple implementations of WCC, however, some implementations seem only work on directed graph, these implementations will not cause an error on undirected graph, but have some small bad performance.
I see networkX only support WCC on directed graph, but, it seems our platform can use WCC both on directed and undirected graph with a small change and have no performance impact, and that's the PR does.
Related issue number
Fixes