Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link grpc on mac m1 #2597

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix link grpc on mac m1 #2597

merged 1 commit into from
Apr 12, 2023

Conversation

siyuan0322
Copy link
Collaborator

Fix building lgraph on M1 Mac.

The libgrpc.dylib should depend on libgpr.dylib, otherwise the linker would fail with message:

Undefined symbols for architecture arm64: "_gpr_assertion_failed", referenced from: Client::Stub::async::addVertices(grpc::ClientContext*, AddVerticesRequest const*, AddVerticesResponse*, grpc::ClientUnaryReactor*) in client.grpc.pb.cc.o Client::Stub::AsyncaddVerticesRaw(grpc::ClientContext*, AddVerticesRequest const&, grpc::CompletionQueue*) in client.grpc.pb.cc.o grpc::ClientAsyncResponseReader<AddVerticesResponse>::StartCall() in client.grpc.pb.cc.o Client::Stub::async::addEdges(grpc::ClientContext*, AddEdgesRequest const*, AddEdgesResponse*, grpc::ClientUnaryReactor*) in client.grpc.pb.cc.o Client::Stub::AsyncaddEdgesRaw(grpc::ClientContext*, AddEdgesRequest const&, grpc::CompletionQueue*) in client.grpc.pb.cc.o grpc::ClientAsyncResponseReader<AddEdgesResponse>::StartCall() in client.grpc.pb.cc.o Client::Stub::async::remoteFlush(grpc::ClientContext*, RemoteFlushRequest const*, RemoteFlushResponse*, grpc::ClientUnaryReactor*) in client.grpc.pb.cc.o ... "_gpr_free", referenced from: grpc::internal::CallOpSet<grpc::internal::CallOpSendInitialMetadata, grpc::internal::CallOpSendMessage, grpc::internal::CallOpRecvInitialMetadata, grpc::internal::CallOpRecvMessage<google::protobuf::MessageLite>, grpc::internal::CallOpClientSendClose, grpc::internal::CallOpClientRecvStatus>::FinalizeResult(void**, bool*) in client.grpc.pb.cc.o grpc::internal::CallOpClientRecvStatus::FinishOp(bool*) in client.grpc.pb.cc.o grpc::internal::CallOpSet<grpc::internal::CallOpSendInitialMetadata, grpc::internal::CallOpSendMessage, grpc::internal::CallOpClientSendClose, grpc::internal::CallOpRecvInitialMetadata, grpc::internal::CallNoOp<5>, grpc::internal::CallNoOp<6> >::FinalizeResult(void**, bool*) in client.grpc.pb.cc.o grpc::internal::CallOpSet<grpc::internal::CallOpSendInitialMetadata, grpc::internal::CallOpSendMessage, grpc::internal::CallOpClientSendClose, grpc::internal::CallOpRecvInitialMe

where these gpr_xxx is defined in libgpr.dylib

@codecov-commenter
Copy link

Codecov Report

Merging #2597 (64be439) into main (0d6bedb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2597   +/-   ##
=======================================
  Coverage   39.90%   39.90%           
=======================================
  Files          88       88           
  Lines        9838     9838           
=======================================
  Hits         3926     3926           
  Misses       5912     5912           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f44323...64be439. Read the comment docs.

@sighingnow sighingnow merged commit 3979f49 into alibaba:main Apr 12, 2023
@siyuan0322 siyuan0322 deleted the zsy/lgraph-mac branch April 12, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants