Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[networkx] refact clear api and implment number_of_selfloops api #266

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Apr 26, 2021

What do these changes do?

  • refact clear api by implement a ClearGraph in engine size.
  • implement number_of_selfloops api and fix number_of_edges bug when graph contain selfloops

Related issue number

#62

@acezen acezen force-pushed the acezen/networkx-selfloops branch 2 times, most recently from 7b476a6 to d24dafb Compare April 27, 2021 06:05
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #266 (21026b1) into main (67a18a7) will decrease coverage by 0.05%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   78.41%   78.35%   -0.06%     
==========================================
  Files          57       57              
  Lines        5281     5286       +5     
==========================================
+ Hits         4141     4142       +1     
- Misses       1140     1144       +4     
Impacted Files Coverage Δ
python/graphscope/framework/dag_utils.py 59.82% <20.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67a18a7...21026b1. Read the comment docs.

@acezen acezen merged commit f1c87e3 into alibaba:main Apr 29, 2021
@yecol yecol linked an issue May 6, 2021 that may be closed by this pull request
@acezen acezen deleted the acezen/networkx-selfloops branch September 3, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release plan for v0.4.0
4 participants