Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the k8s logs of graphscope helm test and upload to artifact when the helm test failed #2683

Merged
merged 3 commits into from
May 10, 2023

Conversation

dashanji
Copy link
Collaborator

@dashanji dashanji commented May 9, 2023

What do these changes do?

As titled.

@dashanji dashanji changed the title Export the k8s logs of graphscope helm test and upload to artifact when failed Export the k8s logs of graphscope helm test and upload to artifact when the helm test failed May 9, 2023
@dashanji dashanji requested a review from siyuan0322 May 9, 2023 08:37
Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Export logs for k8s-ci as well.

Don't touch the graphlearn submodule.

@dashanji
Copy link
Collaborator Author

dashanji commented May 9, 2023

I'm sorry we can't dump the logs of the k8s-ci test at present, and current kubernetes-export-logs can only support dumping all logs at a time rather than a period of time. As all k8s resources are managed by the coordinator, and whether the pytest succeeded or failed, the k8s resources will be deleted after that.

@siyuan0322
Copy link
Collaborator

gss.yaml also has a helm test.

@dashanji dashanji force-pushed the dump-k8s-pod-logs branch 2 times, most recently from b55946d to 6ca6621 Compare May 10, 2023 03:08
@codecov-commenter
Copy link

Codecov Report

Merging #2683 (6ca6621) into main (b258999) will decrease coverage by 32.14%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2683       +/-   ##
===========================================
- Coverage   73.61%   41.48%   -32.14%     
===========================================
  Files          98       98               
  Lines       10317    10306       -11     
===========================================
- Hits         7595     4275     -3320     
- Misses       2722     6031     +3309     

see 55 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a46663e...6ca6621. Read the comment docs.

@dashanji
Copy link
Collaborator Author

dashanji commented May 10, 2023

Added. @sighingnow, @siyuan0322 could you please take a look at this?

…to the artifact.

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@siyuan0322 siyuan0322 merged commit c2cb286 into alibaba:main May 10, 2023
30 checks passed
@dashanji dashanji deleted the dump-k8s-pod-logs branch May 16, 2023 09:32
sighingnow pushed a commit that referenced this pull request May 17, 2023
… during a period of time such as pytest (#2706)

## Related issue number

An optimization for #2683

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants