Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display stderr logs as expected on K8s #2696

Merged
merged 1 commit into from
May 11, 2023
Merged

Display stderr logs as expected on K8s #2696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions coordinator/gscoordinator/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ def ConnectSession(self, request, context):
# Session connected, fetch logs via gRPC.
self._streaming_logs = True
sys.stdout.drop(False)
sys.stderr.drop(False)

return message_pb2.ConnectSessionResponse(
session_id=self._session_id,
Expand Down Expand Up @@ -270,6 +271,7 @@ def CloseSession(self, request, context):

# Session closed, stop streaming logs
sys.stdout.drop(True)
sys.stderr.drop(True)
self._streaming_logs = False
return message_pb2.CloseSessionResponse()

Expand Down
Loading