Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure grape-engine exit when CTRL-C without crash #2761

Merged
merged 1 commit into from May 29, 2023

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

  • Reset the pointer to prevent double-shutdown which causes crash inside grpc
  • Terminate dispatcher (and its queues) correctly when closing

Related issue number

Fixes #2749

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Merging #2761 (852bed9) into main (df16284) will increase coverage by 32.22%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2761       +/-   ##
===========================================
+ Coverage   41.39%   73.61%   +32.22%     
===========================================
  Files          99       99               
  Lines       10381    10392       +11     
===========================================
+ Hits         4297     7650     +3353     
+ Misses       6084     2742     -3342     

see 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df16284...852bed9. Read the comment docs.

@sighingnow sighingnow merged commit e4bb069 into alibaba:main May 29, 2023
22 of 24 checks passed
@sighingnow sighingnow deleted the ht/grape-engine-crash branch May 29, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exiting grape_engine would causing segmentation fault.
2 participants