Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the python sssp result by setting generate_eid to false in load_p2p_network dataset #2762

Merged
merged 1 commit into from
May 29, 2023

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented May 29, 2023

What do these changes do?

🤖 Generated by Copilot at 39ff275

This pull request improves the tutorial for developing algorithms in Python with GraphScope by adding a generate_eid parameter to the load_p2p_network function, which can enhance performance. It also fixes a typo and updates the documentation in both English and Chinese versions.

Related issue number

🤖 Generated by Copilot at 39ff275

  • Add a new parameter generate_eid to the load_p2p_network function in the graphscope.dataset module to allow users to control whether to generate edge IDs for the p2p network graph or not (link, link, link).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

🎊 PR Preview 39ff275 has been successfully built and deployed to https://alibaba-graphscope-build-pr-2762.surge.sh

🤖 By surge-preview

@codecov-commenter
Copy link

Codecov Report

Merging #2762 (39ff275) into main (df16284) will increase coverage by 31.56%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2762       +/-   ##
===========================================
+ Coverage   41.39%   72.96%   +31.56%     
===========================================
  Files          99       99               
  Lines       10381    10381               
===========================================
+ Hits         4297     7574     +3277     
+ Misses       6084     2807     -3277     
Impacted Files Coverage Δ
python/graphscope/dataset/p2p_network.py 87.50% <100.00%> (+56.25%) ⬆️

... and 52 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df16284...39ff275. Read the comment docs.

@sighingnow sighingnow merged commit a119c23 into alibaba:main May 29, 2023
40 checks passed
@sighingnow sighingnow deleted the develop branch May 29, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants