Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GetInnerVertex() by querying local fragment only #2772

Merged
merged 3 commits into from May 30, 2023

Conversation

songqing
Copy link
Contributor

What do these changes do?

The current implementation of GetInnerVertex() is to query all the fragment, it's not needed as we only need the inner vertex

Signed-off-by: songqing <zhangsongqing164@163.com>
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #2772 (cf75abd) into main (bf8d7b0) will increase coverage by 26.70%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2772       +/-   ##
===========================================
+ Coverage   41.39%   68.10%   +26.70%     
===========================================
  Files          99       99               
  Lines       10381    10392       +11     
===========================================
+ Hits         4297     7077     +2780     
+ Misses       6084     3315     -2769     

see 61 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8d7b0...cf75abd. Read the comment docs.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow merged commit 5b46a68 into alibaba:main May 30, 2023
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants