[BugFix] Make the error message truncated not so aggressive #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
sighingnow
reviewed
Jun 13, 2023
| @@ -111,7 +111,7 @@ def _generate_runstep_request(session_id, dag_def, dag_bodies): | |||
| # TODO: make the stacktrace separated from normal error messages | |||
| # Too verbose. | |||
| if len(e.details()) > 3072: # 3k bytes | |||
| msg = f"{e.details()[:30]} ... [truncated]" | |||
| msg = f"{e.details()[:1014]} ... [truncated]" | |||
There was a problem hiding this comment.
1014 is too long. 80 or 256 would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
code shows that when error message is too large, truncated to 30 chars. BUT A snippet of 30 chars is usually not enough to tell something useful. This change enlarge the 30 to 1024 to show more log.
Related issue number
Fixes #2864