[GAE-Java] Relax version enforce for some mvn dependencies #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yecol
reviewed
Jun 15, 2023
| @@ -83,7 +83,6 @@ | |||
| <dependency> | |||
| <groupId>com.google.guava</groupId> | |||
| <artifactId>guava</artifactId> | |||
| <version>31.0.1-android</version> | |||
| </dependency> | |||
There was a problem hiding this comment.
Are you missing a line here?
<version>${guava.version}</version>
There was a problem hiding this comment.
The version control of all dependencies in child module can be uplift to parent module, so we don't need to specify the version here, let me add one more commit.
sighingnow
approved these changes
Jun 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2894 +/- ##
==========================================
+ Coverage 66.83% 73.96% +7.13%
==========================================
Files 99 99
Lines 10687 10687
==========================================
+ Hits 7143 7905 +762
+ Misses 3544 2782 -762 see 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading
guavaforGAE Java SDK, there seems to be some problem withmaven-enforcer-plugin. Relax this version control.