[good-first-issue]Move save_to/load_from from client side to coordinator
#2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglei1949
force-pushed
the
save_to_at_coordinator
branch
from
4b2e2bf
to
cb8da51
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
=======================================
Coverage ? 73.34%
=======================================
Files ? 99
Lines ? 10661
Branches ? 0
=======================================
Hits ? 7819
Misses ? 2842
Partials ? 0
Continue to review full report in Codecov by Sentry.
|
sighingnow
reviewed
Jun 19, 2023
|
/cc @siyuan0322 @acezen |
siyuan0322
approved these changes
Jun 20, 2023
Committed-by: zhanglei1949 from Dev container e Committed-by: zhanglei1949 from Dev container format Committed-by: zhanglei1949 from Dev container Committed-by: zhanglei1949 from Dev container
Co-authored-by: Tao He <sighingnow@gmail.com>
zhanglei1949
force-pushed
the
save_to_at_coordinator
branch
from
85e7660
to
49ca8c8
Compare
zhanglei1949
changed the title
save_to/load_from from client side to coordinatorsave_to/load_from from client side to coordinator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current graph serialization and deserialization is performed at client side, which should be done on coordiantor.
#1982