-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python][Client] Unify the graph level load_from
and save to
API
#2919
Conversation
6f5d594
to
e5886f5
Compare
load_from
and save to
API
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
==========================================
- Coverage 41.39% 34.84% -6.55%
==========================================
Files 107 107
Lines 11203 11309 +106
==========================================
- Hits 4637 3941 -696
- Misses 6566 7368 +802
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Returns: | ||
`Graph`: A new graph object. Schema and data is supposed to be | ||
identical with the one that called serialized method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
python/graphscope/framework/graph.py
Outdated
graphar_vertex_block_size=262144, # 2^18 | ||
graphar_edge_block_size=4194304, # 2^22 | ||
graphar_file_format="parquet", | ||
graphar_version="v1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more clear to pass graphar related parameters in a dict, not messed up with other parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's our design discuss in issue #2957 , and the parameters are like Session
init method's parameter.
80cf33b
to
d21e949
Compare
d21e949
to
1a1241b
Compare
38b87d2
to
34a0d9a
Compare
34a0d9a
to
54ddef3
Compare
f2f310e
to
9ec8e2e
Compare
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com> Add doc Update Update Unify the API Runnable Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com> Committed-by: acezen from Dev container Committed-by: acezen from Dev container Committed-by: acezen from Dev container Rebase Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com> Committed-by: acezen from Dev container Format Committed-by: acezen from Dev container Fix Committed-by: acezen from Dev container Update Committed-by: acezen from Dev container Fix Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com> Committed-by: acezen from Dev container Fix Committed-by: acezen from Dev container Committed-by: acezen from Dev container Committed-by: acezen from Dev container Committed-by: acezen from Dev container Format Committed-by: acezen from Dev container Committed-by: acezen from Dev container Update Committed-by: acezen from Dev container Committed-by: acezen from Dev container Update Format Committed-by: acezen from Dev container
Committed-by: acezen from Dev container Committed-by: acezen from Dev container
Committed-by: acezen from Dev container
Committed-by: acezen from Dev container Committed-by: acezen from Dev container
9ec8e2e
to
1ea86b3
Compare
this PR is outdated, create a new pull request #3610 |
This is a prototype implementation of the design of
load_from
andwrite_to
Python APIrelated issue: #2836
Use examples: