Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementMap step support #2942

Merged
merged 2 commits into from Jun 28, 2023
Merged

ElementMap step support #2942

merged 2 commits into from Jun 28, 2023

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented Jun 27, 2023

What do these changes do?

gremlin> g.V(1,2,4).elementMap()
==>{label=person, id=1, name=marko, id=1, age=29}
==>{label=person, id=2, name=vadas, id=2, age=27}
==>{label=person, id=4, name=josh, id=4, age=32}

gremlin> g.V(1,2,4).elementMap("name", "age")
==>{age=27, label=person, id=2, name=vadas}
==>{age=32, label=person, id=4, name=josh}
==>{age=29, label=person, id=1, name=marko}

gremlin> g.V().elementMap()
==>{label=person, id=2, name=vadas, id=2, age=27}
==>{label=software, id=72057594037927941, name=ripple, id=5, lang=java}
==>{label=person, id=1, name=marko, id=1, age=29}
==>{label=software, id=72057594037927939, name=lop, id=3, lang=java}
==>{label=person, id=4, name=josh, id=4, age=32}
==>{label=person, id=6, name=peter, id=6, age=35}

Compare to the official result, now g.E().elementMap() lack the information of in(out)'s vertices

# our result
gremlin> g.E().elementMap()
==>{label=knows, id=0, start_id=0.5, end_id=0.5, weight=0.5}

# official result
gremlin> g.E().elementMap()
==>{label=knows, id=0, start_id=0.5, end_id=0.5, weight=0.5, IN=[label=person, id=0], OUT=[label=person, id=1]}

Related issue number

Fixes #2778

@codecov-commenter
Copy link

Codecov Report

Merging #2942 (cf2cb06) into main (badf3f3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2942   +/-   ##
=======================================
  Coverage   42.31%   42.31%           
=======================================
  Files          99       99           
  Lines       10631    10631           
=======================================
  Hits         4499     4499           
  Misses       6132     6132           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update badf3f3...cf2cb06. Read the comment docs.

@sighingnow sighingnow merged commit 7035c0a into alibaba:main Jun 28, 2023
25 checks passed
@sighingnow sighingnow deleted the develop branch June 28, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GIE] 'ElementMap' operator support
4 participants