Enable perfect hash support in GAE #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuan0322
previously approved these changes
Jul 3, 2023
| @@ -265,7 +268,8 @@ def __init__( | |||
| Defaults to global. | |||
| compact_edges (bool, optional): Compact edges (CSR) using varint and delta encoding. Defaults to False. | |||
| Note that compact edges helps to half the memory usage of edges in graph data structure, but may cause | |||
| at most 10%~20% performance degeneration in some algorithms. | |||
| at most 10%~20% performance degeneration in some algorithms. Defaults to False. | |||
| use_perfect_hash (bool, optional): Use perfect hash in vertex map to optimize the memory usage. Defaults to False. | |||
There was a problem hiding this comment.
Add a comment saying it only works for oid type int64_t? It I understand correctly.
There was a problem hiding this comment.
Or just check the oid and log error.
There was a problem hiding this comment.
Works for string oid as well.
sighingnow
force-pushed
the
ht/use-perfect-hash
branch
from
4da94ee
to
eccc5db
Compare
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
sighingnow
force-pushed
the
ht/use-perfect-hash
branch
from
eccc5db
to
ba1b528
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2959 +/- ##
===========================================
+ Coverage 42.40% 73.31% +30.91%
===========================================
Files 99 99
Lines 10699 10733 +34
===========================================
+ Hits 4537 7869 +3332
+ Misses 6162 2864 -3298
... and 50 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.