Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compliation error for non-builtin frames on MacOS #2972

Merged

Conversation

sighingnow
Copy link
Collaborator

@sighingnow sighingnow commented Jul 5, 2023

What do these changes do?

See also: https://github.com/alibaba/GraphScope/actions/runs/5457744215

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #2972 (a12e330) into main (731d5a3) will increase coverage by 28.82%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2972       +/-   ##
===========================================
+ Coverage   45.07%   73.90%   +28.82%     
===========================================
  Files          99       99               
  Lines       10660    10660               
===========================================
+ Hits         4805     7878     +3073     
+ Misses       5855     2782     -3073     

see 53 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731d5a3...a12e330. Read the comment docs.

@sighingnow sighingnow merged commit cdf8555 into alibaba:main Jul 5, 2023
25 checks passed
@sighingnow sighingnow deleted the ht/fixes-macos-compilation-error branch July 5, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants