[GIE Doc] Refine Docs for Cypher #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirly121
changed the title
longbinlai
reviewed
Jul 11, 2023
| @@ -74,10 +74,11 @@ deployment and management of applications. To deploy GIE standalone using Helm, | |||
| kubectl describe svc [YOUR_RELEASE_NAME]-gie-standalone-frontend \ | |||
| | grep "Endpoints:" | awk -F' ' '{print $2}' | |||
| ``` | |||
| You should see the GIE Frontend service endpoint as `<ip>:<gremlinPort>`. | |||
| You should see two exposed endpoints for GIE Frontend service, one is `<ip>:<gremlinPort>` for gremlin querying, another is `<ip>:<cypherPort>` for cypher querying. | |||
There was a problem hiding this comment.
Explicitly use two commands, one for obtaining Cypher endpoint, the other for Gremlin endpoint.
longbinlai
reviewed
Jul 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2995 +/- ##
===========================================
- Coverage 73.91% 42.38% -31.53%
===========================================
Files 99 99
Lines 10698 10687 -11
===========================================
- Hits 7907 4530 -3377
- Misses 2791 6157 +3366 see 59 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
longbinlai
reviewed
Jul 12, 2023
longbinlai
reviewed
Jul 12, 2023
| @@ -102,7 +102,7 @@ You could pass additional key-value pairs to customize the startup configuration | |||
|
|
|||
| ```python | |||
| # Set the timeout value to 10 min | |||
| g = gs.gremlin(graph, params={'pegasus.timeout': 600000}) | |||
| g = gs.gremlin(graph, params={'query.execution.timeout.ms': 600000}) | |||
There was a problem hiding this comment.
How this may be configured with the new python apis?
longbinlai
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
as titled.
Related issue number
Fixes #2987