Use arrow::LargeStringArray in trivial_tensor_t to store data larger than 2GB #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsor_t Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
sighingnow
approved these changes
Jul 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2999 +/- ##
===========================================
+ Coverage 42.38% 73.91% +31.52%
===========================================
Files 99 99
Lines 10687 10698 +11
===========================================
+ Hits 4530 7907 +3377
+ Misses 6157 2791 -3366 see 59 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Replace arrow::StringArray with arrow::LargeStringArray in trivial_tensor_t which can store data larger than 2GB
Related issue number
Fixes #2998