Implement grin interface for flex #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| typedef std::vector<gs::label_t> GRIN_VERTEX_TYPE_LIST_T; | ||
|
|
||
| typedef struct GRIN_VERTEX_PROPERTY_T { | ||
| std::string name; |
There was a problem hiding this comment.
[future optimize] caching static schema-data in the graph handle would be a good practice to simplify the data structures for better performance. Please refer to the v6d implementation for caching.
luoxiaojian
previously approved these changes
Jul 19, 2023
| } | ||
| auto& table = _g->get_vertex_table(plabel); | ||
| auto col = | ||
| std::dynamic_pointer_cast<gs::IntColumn>(table.get_column_by_id(pid)); |
There was a problem hiding this comment.
Try to avoid dynamic_pointer_cast in get_value apis, based on the performance benchmark of grin-v6d, this can be 20-30 times slower. Instead, you can cache these columns as void* and then static_cast them back to the type you need in these apis.
luoxiaojian
approved these changes
Jul 19, 2023
sighingnow
added a commit
that referenced
this pull request
Jul 26, 2023
The submodule was first introduced in #3010 and it should be removed before `git add -A` to gh-pages. Fixes https://github.com/alibaba/GraphScope/actions/runs/5665819421/job/15351324239 --------- Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
zhanglei1949
pushed a commit
to zhanglei1949/GraphScope
that referenced
this pull request
Jul 28, 2023
…a#3056) The submodule was first introduced in alibaba#3010 and it should be removed before `git add -A` to gh-pages. Fixes https://github.com/alibaba/GraphScope/actions/runs/5665819421/job/15351324239 --------- Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Implement grin interface for flex.
Related issue number
.