Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify gae, python and groot proto into proto directory #3023

Merged
merged 8 commits into from Jul 19, 2023

Conversation

siyuan0322
Copy link
Collaborator

What do these changes do?

Related issue number

Related to #3014

@longbinlai
Copy link
Collaborator

Can we arrange the proto dir as the flex dir? with a stores dir for all graph store in graphscope, with an engines dir for all engines in graphscope?

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #3023 (a3dd6a3) into main (cbe3df3) will increase coverage by 31.86%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3023       +/-   ##
===========================================
+ Coverage   42.42%   74.29%   +31.86%     
===========================================
  Files          99       99               
  Lines       10733    10696       -37     
===========================================
+ Hits         4554     7947     +3393     
+ Misses       6179     2749     -3430     
Impacted Files Coverage Δ
python/graphscope/proto/__init__.py 100.00% <100.00%> (ø)

... and 60 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe3df3...a3dd6a3. Read the comment docs.

@sighingnow sighingnow merged commit 73df0a3 into alibaba:main Jul 19, 2023
24 of 29 checks passed
@siyuan0322 siyuan0322 deleted the zsy/proto branch July 21, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants