Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix networkx add edge segment fault bug #3032

Merged
merged 5 commits into from Jul 24, 2023

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Jul 18, 2023

What do these changes do?

This change fix the bug that networkx add edges like [(0, 1), (1, 2)], the vertex 1 has added by

bool src_new_add = vm_ptr_->AddVertex(std::move(src), src_gid);
bool dst_new_add = vm_ptr_->AddVertex(std::move(dst), dst_gid);

when process edge (0, 1), but iv_alive_ not extend yet
when process (1, 2), the vertex 1 would check again in fragment_->iv_alive_.get_bit(lid), it would crash since lid is large than its cardinality.

Related issue number

Fixes #3028

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #3032 (abd9f59) into main (c1df6f2) will increase coverage by 31.71%.
The diff coverage is 84.88%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3032       +/-   ##
===========================================
+ Coverage   42.62%   74.34%   +31.71%     
===========================================
  Files          99       99               
  Lines       10685    10699       +14     
===========================================
+ Hits         4555     7954     +3399     
+ Misses       6130     2745     -3385     
Impacted Files Coverage Δ
python/graphscope/analytical/app/pagerank.py 71.42% <50.00%> (+7.53%) ⬆️
python/graphscope/tests/conftest.py 88.00% <57.89%> (+40.12%) ⬆️
python/graphscope/analytical/app/wcc.py 95.45% <75.00%> (+13.63%) ⬆️
python/graphscope/tests/unittest/test_app.py 96.80% <96.36%> (+96.80%) ⬆️
python/graphscope/analytical/app/__init__.py 100.00% <100.00%> (ø)
python/graphscope/analytical/app/clustering.py 100.00% <100.00%> (+37.50%) ⬆️

... and 54 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3a32b...abd9f59. Read the comment docs.

@acezen acezen force-pushed the 3028-fix-networkx-add-edges-seg-fault branch from 7826ac7 to e69d217 Compare July 21, 2023 01:43
@acezen acezen changed the title Fix networkx add edge segment fault bug [BugFix] Fix networkx add edge segment fault bug Jul 21, 2023
Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sighingnow sighingnow merged commit 02dd978 into alibaba:main Jul 24, 2023
22 of 23 checks passed
@sighingnow sighingnow deleted the 3028-fix-networkx-add-edges-seg-fault branch July 24, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Networkx ModifyEdges method segmentation fault on CI.
4 participants