Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytical): Add the Graph.consolidate_columns() interface in Python client #3060

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

sighingnow
Copy link
Collaborator

No description provided.

…hon SDK

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow changed the title feat(analytical) Add the Graph.consolidate_columns() interface in Python client feat(analytical): Add the Graph.consolidate_columns() interface in Python client Jul 27, 2023
andydiwenzhu
andydiwenzhu previously approved these changes Jul 27, 2023
Copy link
Collaborator

@andydiwenzhu andydiwenzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3060 (5080a01) into main (422d0b6) will decrease coverage by 6.90%.
Report is 1 commits behind head on main.
The diff coverage is 35.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
- Coverage   42.67%   35.78%   -6.90%     
==========================================
  Files         100      100              
  Lines       10713    10787      +74     
==========================================
- Hits         4572     3860     -712     
- Misses       6141     6927     +786     
Files Changed Coverage Δ
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (ø)
python/graphscope/tests/conftest.py 47.61% <28.57%> (-0.67%) ⬇️
python/graphscope/framework/dag_utils.py 37.38% <45.45%> (-7.14%) ⬇️
python/graphscope/framework/utils.py 47.05% <55.55%> (+3.99%) ⬆️
python/graphscope/framework/graph.py 62.31% <59.09%> (-7.42%) ⬇️

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c585137...5080a01. Read the comment docs.

@sighingnow sighingnow merged commit f590fd1 into alibaba:main Jul 27, 2023
40 of 46 checks passed
@sighingnow sighingnow deleted the ht/fix-add-consolidate branch July 27, 2023 09:20
zhanglei1949 pushed a commit to zhanglei1949/GraphScope that referenced this pull request Jul 28, 2023
…thon client (alibaba#3060)

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants