Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytical): fixes wrong result when flatten from projected arrow fragment #3066

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

hanjf12
Copy link
Contributor

@hanjf12 hanjf12 commented Aug 1, 2023

fix error: wrong result when flatten from projected data

What do these changes do?

Related issue number

Fixes

fix error: wrong result when flatten from projected data
@welcome
Copy link

welcome bot commented Aug 1, 2023

Thanks for submitting your first pull request! You are awesome! 🤗
Please make sure you have signed the CLA, as this is a mandatory check before a PR being merged.
Welcome to the GraphScope community! 🎉 You can meet the community on DingTalk or Slack.

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2023

CLA assistant check
All committers have signed the CLA.

sighingnow
sighingnow previously approved these changes Aug 1, 2023
@sighingnow sighingnow changed the title Update arrow_flattened_fragment.h fix: fixes wrong result when flatten from projected arrow fragment Aug 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #3066 (89e0572) into main (33576bf) will decrease coverage by 38.91%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3066       +/-   ##
===========================================
- Coverage   74.72%   35.81%   -38.91%     
===========================================
  Files         100      100               
  Lines       10823    10820        -3     
===========================================
- Hits         8087     3875     -4212     
- Misses       2736     6945     +4209     

see 68 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33576bf...89e0572. Read the comment docs.

@sighingnow
Copy link
Collaborator

@hanjf12 Could you please address the format issue by following the guidance in the message? https://github.com/alibaba/GraphScope/actions/runs/5722335994/job/15506017197?pr=3066

Thanks!

@sighingnow sighingnow changed the title fix: fixes wrong result when flatten from projected arrow fragment fix(gae): fixes wrong result when flatten from projected arrow fragment Aug 1, 2023
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow changed the title fix(gae): fixes wrong result when flatten from projected arrow fragment fix(analytical): fixes wrong result when flatten from projected arrow fragment Aug 1, 2023
@sighingnow sighingnow merged commit 62ec0c6 into alibaba:main Aug 1, 2023
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants