Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interactive): throw unsupported error when query PathExpand() within subtask #3133

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix(interactive): throw unsupported error when query PathExpand() within subtask #3133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33d18c1
[bug fix] throw unsupported error when use PathExpand() within subtask
BingqingLyu Aug 18, 2023
5a8c02c
Merge branch 'main' into ir_apply_iter_unsupported
BingqingLyu Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions interactive_engine/executor/ir/core/src/plan/physical.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,17 @@ impl AsPhysical for LogicalPlan {
if let Some(Apply(apply_opr)) = curr_node.borrow().opr.opr.as_ref() {
let mut sub_bldr = PlanBuilder::default();
if let Some(subplan) = self.extract_subplan(curr_node.clone()) {
for (_, node) in &subplan.nodes {
let operator = node.borrow().opr.clone();
match operator.opr.as_ref() {
// TODO(bingqing): remove this when engine supports.
Some(pb::logical_plan::operator::Opr::Path(_)) => {
Err(IrError::Unsupported("PathExpand in Apply".to_string()))?
}
_ => {}
}
}

let mut expand_degree_opt = None;
if subplan.len() <= 2 {
if subplan.len() == 1 {
Expand Down
Loading