Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(learning): bump torch from 1.13 to 1.13.1 in /python #3264

Merged
merged 1 commit into from Sep 26, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 25, 2023

Bumps torch from 1.13 to 1.13.1.

Release notes

Sourced from torch's releases.

PyTorch 1.13.1 Release, small bug fix release

This release is meant to fix the following issues (regressions / silent correctness):

  • RuntimeError by torch.nn.modules.activation.MultiheadAttention with bias=False and batch_first=True #88669
  • Installation via pip on Amazon Linux 2, regression #88869
  • Installation using poetry on Mac M1, failure #88049
  • Missing masked tensor documentation #89734
  • torch.jit.annotations.parse_type_line is not safe (command injection) #88868
  • Use the Python frame safely in _pythonCallstack #88993
  • Double-backward with full_backward_hook causes RuntimeError #88312
  • Fix logical error in get_default_qat_qconfig #88876
  • Fix cuda/cpu check on NoneType and unit test #88854 and #88970
  • Onnx ATen Fallback for BUILD_CAFFE2=0 for ONNX-only ops #88504
  • Onnx operator_export_type on the new registry #87735
  • torchrun AttributeError caused by file_based_local_timer on Windows #85427

The release tracker should contain all relevant pull requests related to this release as well as links to related issues

Changelog

Sourced from torch's changelog.

Releasing PyTorch

Release Compatibility Matrix

Following is the Release Compatibility Matrix for PyTorch releases:

PyTorch version Python Stable CUDA Experimental CUDA
2.1 >=3.8, <=3.11 CUDA 11.8, CUDNN 8.7.0.84 CUDA 12.1, CUDNN 8.9.2.26
2.0 >=3.8, <=3.11 CUDA 11.7, CUDNN 8.5.0.96 CUDA 11.8, CUDNN 8.7.0.84
1.13 >=3.7, <=3.10 CUDA 11.6, CUDNN 8.3.2.44 CUDA 11.7, CUDNN 8.5.0.96

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Sep 25, 2023
Bumps [torch](https://github.com/pytorch/pytorch) from 1.13 to 1.13.1.
- [Release notes](https://github.com/pytorch/pytorch/releases)
- [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md)
- [Commits](pytorch/pytorch@v1.13.0...v1.13.1)

---
updated-dependencies:
- dependency-name: torch
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@LiSu LiSu force-pushed the dependabot/pip/python/torch-1.13.1 branch from 3865c24 to b276ae3 Compare September 26, 2023 01:56
@LiSu LiSu self-requested a review September 26, 2023 01:56
@LiSu LiSu changed the title build(deps): bump torch from 1.13 to 1.13.1 in /python build(learning): bump torch from 1.13 to 1.13.1 in /python Sep 26, 2023
@sighingnow
Copy link
Collaborator

I suggest we don't include pytorch in the requirements.txt, as what the user actually want may not be the version fetched using pip (e.g., they may require (or already have) a GPU-enabled variant).

Like tensorflow, we could raise warnings or leave a note in the documentation to tell users to install pytorch properly.

Or, we could have a profile like graphscope[torch] (with something added into the setup.py) which will introduce the dependency, rather than requires it by default.

Besides, pin to a certain version of pytorch may causing issues in the user side as well, considering pytorch APIs are fairly stable, could we have something like torch>=0.13.1?

@sighingnow sighingnow merged commit 0ff61bf into main Sep 26, 2023
28 of 29 checks passed
@sighingnow sighingnow deleted the dependabot/pip/python/torch-1.13.1 branch September 26, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants