Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): extension use hash(srcId, dstId, edgeLabelId, edgePks) instead of increase eid #3357

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

bufapiqi
Copy link
Contributor

What do these changes do?

extension use hash(srcId, dstId, edgeLabelId, edgePks) to generate eid.
It can support edge update scenarios where eid is not known in advance.
Compatible with the original way of generating eid, use "enable.hash.generate.eid parameter" to judge
if enable.hash.generate.eid parameter=true:
use hash generate
else:
use increase generate

Related issue number

Fixes

Copy link

welcome bot commented Nov 16, 2023

Thanks for submitting your first pull request! You are awesome! 🤗
Please make sure you have signed the CLA, as this is a mandatory check before a PR being merged.
Welcome to the GraphScope community! 🎉 You can meet the community on DingTalk or Slack.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@bufapiqi bufapiqi changed the title extension use hash(srcId, dstId, edgeLabelId, edgePks) instead of increase eid fix(interactive): extension use hash(srcId, dstId, edgeLabelId, edgePks) instead of increase eid Nov 16, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3357 (5729d05) into main (3a9ee80) will not change coverage.
Report is 15 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3357   +/-   ##
=======================================
  Coverage   41.04%   41.04%           
=======================================
  Files         109      109           
  Lines       11298    11298           
=======================================
  Hits         4637     4637           
  Misses       6661     6661           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9ee80...5729d05. Read the comment docs.

Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well down! 👍

@siyuan0322 siyuan0322 merged commit 41bc5ae into alibaba:main Nov 16, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants