Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactive): Introduce Graph Type Inference in Compiler #3375

Merged
merged 21 commits into from
Jan 8, 2024

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Nov 27, 2023

What do these changes do?

as titled.

Related issue number

Fixes

@shirly121 shirly121 marked this pull request as ready for review December 20, 2023 12:19
@shirly121 shirly121 changed the title feature(interactive): Introduce Graph Type Inference in Compiler feat(interactive): Introduce Graph Type Inference in Compiler Dec 20, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (608f814) 41.04% compared to head (c45cf27) 40.90%.
Report is 32 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3375      +/-   ##
==========================================
- Coverage   41.04%   40.90%   -0.14%     
==========================================
  Files         109      109              
  Lines       11298    11343      +45     
==========================================
+ Hits         4637     4640       +3     
- Misses       6661     6703      +42     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608f814...c45cf27. Read the comment docs.

@shirly121
Copy link
Collaborator Author

shirly121 commented Jan 5, 2024

  1. configuration to enable/disable type inference added in f60ad0e
  2. end-to-end tests added in 52fafe8
  3. add unit tests when type inference is disabled in 9dd7727

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longbinlai longbinlai merged commit e67f8d7 into alibaba:main Jan 8, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants