-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interactive): Refactor and fix some bugs for AdminService
#3406
Conversation
a5f011c
to
2ca785a
Compare
AdminService
AdminService
AdminService
AdminService
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3406 +/- ##
=======================================
Coverage 27.76% 27.76%
=======================================
Files 178 178
Lines 16245 16245
=======================================
Hits 4511 4511
Misses 11734 11734 Continue to review full report in Codecov by Sentry.
|
AdminService
AdminService
5a02274
to
d632f2a
Compare
author xiaolei.zl <xiaolei.zl@alibaba-inc.com> 1701935806 +0800 committer xiaolei.zl <xiaolei.zl@alibaba-inc.com> 1710748155 +0800 1. set default stored_procedures for graph schema. 2. use nlohmann-json to convert yaml to json fix some bug fix workflow file make loading_method enum ongoing: change http return code fix bug fix fix fix fix fix error fix fix make load graph sync support non-blocking dataloading fix bug and make job_id string fix start/end_time fix resource object lock_file and AtomicIntDecrementer fix adhoc fix rebase and refine minor fix refactor minor refine doc fix fix aocc warning can start compiler in interactive_server rename fix minor format minor fix fix fix fix
835d706
to
8fc19e1
Compare
This PR has been divided into several small, merged PRs into main. |
In this PR, we refactor some of the Interactive
AdminService
and fix some bugs.bulk_loading_job_count_
.AdminActor
APIs returnseastar::future<gs::Result<seastar::sstring>>
, with a mapping betweengs::StatusCode
and http status code, we can remove a lot of dummy code handling exception/unexpected behaviors.Fix #3515