Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: coordinator and gsctl under FLEX architecture #3481

Merged
merged 12 commits into from
Jan 30, 2024

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented Jan 15, 2024

What do these changes do?

Related issue number

@lidongze0629 lidongze0629 changed the title [WIP] Refactor coordinator and gsctl under FLEX architecture refactor: coordinator and gsctl under FLEX architecture Jan 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7a0d93) 64.71% compared to head (1065aaa) 61.27%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3481      +/-   ##
==========================================
- Coverage   64.71%   61.27%   -3.45%     
==========================================
  Files         110      117       +7     
  Lines       11452    11968     +516     
==========================================
- Hits         7411     7333      -78     
- Misses       4041     4635     +594     
Files Coverage Δ
python/graphscope/gsctl/commands/__init__.py 0.00% <ø> (ø)
python/graphscope/gsctl/commands/common.py 0.00% <ø> (ø)
python/graphscope/gsctl/commands/dev.py 0.00% <ø> (ø)
python/graphscope/gsctl/commands/interactive.py 0.00% <ø> (ø)
python/graphscope/gsctl/config.py 0.00% <ø> (ø)
python/graphscope/gsctl/gsctl.py 0.00% <ø> (ø)
python/graphscope/gsctl/impl/__init__.py 0.00% <ø> (ø)
python/graphscope/gsctl/impl/alert.py 0.00% <ø> (ø)
python/graphscope/gsctl/impl/common.py 0.00% <ø> (ø)
python/graphscope/gsctl/impl/deployment.py 0.00% <ø> (ø)
... and 5 more

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a17e5c...1065aaa. Read the comment docs.

@lidongze0629 lidongze0629 merged commit 913250f into alibaba:main Jan 30, 2024
53 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor and reorg of gsctl and gs_interactive Unify the code paths to coordinator from gsctl and WebUI
3 participants