Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes spelling in analytical engine core #3587

Merged
merged 15 commits into from Mar 7, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 28, 2024

What do these changes do?

Fixes spelling errors in comments per #3547 (comment)

Related issue number

@jsoref jsoref marked this pull request as draft February 28, 2024 14:36
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref force-pushed the spelling-analytical_engine-core branch from 3315329 to f0ceb36 Compare February 28, 2024 14:38
@jsoref jsoref marked this pull request as ready for review February 28, 2024 14:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.03%. Comparing base (d3a40e8) to head (d734519).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3587       +/-   ##
===========================================
+ Coverage   27.79%   43.03%   +15.23%     
===========================================
  Files         178      179        +1     
  Lines       16231    18573     +2342     
===========================================
+ Hits         4511     7992     +3481     
+ Misses      11720    10581     -1139     

see 119 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a40e8...d734519. Read the comment docs.

@sighingnow
Copy link
Collaborator

There seems some C++ format errors, could you please apply the fixes as described in the error message https://github.com/alibaba/GraphScope/actions/runs/8082152799/job/22112842992?pr=3587 ?

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Copy link
Contributor Author

jsoref commented Mar 1, 2024

Sure. Fwiw the output in that log run suffers from damage to leading whitespace:

as presented in the log (with `|` stripped)
diff --git a/analytical_engine/core/fragment/arrow_projected_fragment.h b/analytical_engine/core/fragment/arrow_projected_fragment.h
index 36115e78..dea39672 100644
--- a/analytical_engine/core/fragment/arrow_projected_fragment.h
+++ b/analytical_engine/core/fragment/arrow_projected_fragment.h
@@ -1141,9 +1141,9 @@ class ArrowProjectedFragment
oe_splitters_ptr_.clear();
if (directed_) {
initEdgeSplitters(comm_spec, ie_, ie_offsets_begin_, ie_offsets_end_,
-                         ie_splitters_);
+                          ie_splitters_);
initEdgeSplitters(comm_spec, oe_, oe_offsets_begin_, oe_offsets_end_,
-                         oe_splitters_);
+                          oe_splitters_);
for (auto& vec : ie_splitters_) {
ie_splitters_ptr_.push_back(vec.data());
}
@@ -1152,7 +1152,7 @@ class ArrowProjectedFragment
}
} else {
initEdgeSplitters(comm_spec, oe_, oe_offsets_begin_, oe_offsets_end_,
-                         oe_splitters_);
+                          oe_splitters_);
for (auto& vec : oe_splitters_) {
ie_splitters_ptr_.push_back(vec.data());
oe_splitters_ptr_.push_back(vec.data());
with changes manually applied
diff --git a/analytical_engine/core/fragment/arrow_projected_fragment.h b/analytical_engine/core/fragment/arrow_projected_fragment.h
index 36115e78..dea39672 100644
--- a/analytical_engine/core/fragment/arrow_projected_fragment.h
+++ b/analytical_engine/core/fragment/arrow_projected_fragment.h
@@ -1141,9 +1141,9 @@ class ArrowProjectedFragment
       oe_splitters_ptr_.clear();
       if (directed_) {
         initEdgeSplitters(comm_spec, ie_, ie_offsets_begin_, ie_offsets_end_,
-                         ie_splitters_);
+                          ie_splitters_);
         initEdgeSplitters(comm_spec, oe_, oe_offsets_begin_, oe_offsets_end_,
-                         oe_splitters_);
+                          oe_splitters_);
         for (auto& vec : ie_splitters_) {
           ie_splitters_ptr_.push_back(vec.data());
         }
@@ -1152,7 +1152,7 @@ class ArrowProjectedFragment
         }
       } else {
         initEdgeSplitters(comm_spec, oe_, oe_offsets_begin_, oe_offsets_end_,
-                         oe_splitters_);
+                          oe_splitters_);
         for (auto& vec : oe_splitters_) {
           ie_splitters_ptr_.push_back(vec.data());
           oe_splitters_ptr_.push_back(vec.data());

@jsoref jsoref force-pushed the spelling-analytical_engine-core branch from f0ceb36 to d734519 Compare March 1, 2024 12:27
@sighingnow sighingnow changed the title Spelling analytical engine core fix: fixes spelling in analytical engine core Mar 6, 2024
@sighingnow sighingnow merged commit 987d7b9 into alibaba:main Mar 7, 2024
29 checks passed
@jsoref jsoref deleted the spelling-analytical_engine-core branch March 7, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants