-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes spelling in analytical engine core #3587
fix: fixes spelling in analytical engine core #3587
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
3315329
to
f0ceb36
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3587 +/- ##
===========================================
+ Coverage 27.79% 43.03% +15.23%
===========================================
Files 178 179 +1
Lines 16231 18573 +2342
===========================================
+ Hits 4511 7992 +3481
+ Misses 11720 10581 -1139 see 119 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There seems some C++ format errors, could you please apply the fixes as described in the error message https://github.com/alibaba/GraphScope/actions/runs/8082152799/job/22112842992?pr=3587 ? |
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Sure. Fwiw the output in that log run suffers from damage to leading whitespace: as presented in the log (with `|` stripped)diff --git a/analytical_engine/core/fragment/arrow_projected_fragment.h b/analytical_engine/core/fragment/arrow_projected_fragment.h
index 36115e78..dea39672 100644
--- a/analytical_engine/core/fragment/arrow_projected_fragment.h
+++ b/analytical_engine/core/fragment/arrow_projected_fragment.h
@@ -1141,9 +1141,9 @@ class ArrowProjectedFragment
oe_splitters_ptr_.clear();
if (directed_) {
initEdgeSplitters(comm_spec, ie_, ie_offsets_begin_, ie_offsets_end_,
- ie_splitters_);
+ ie_splitters_);
initEdgeSplitters(comm_spec, oe_, oe_offsets_begin_, oe_offsets_end_,
- oe_splitters_);
+ oe_splitters_);
for (auto& vec : ie_splitters_) {
ie_splitters_ptr_.push_back(vec.data());
}
@@ -1152,7 +1152,7 @@ class ArrowProjectedFragment
}
} else {
initEdgeSplitters(comm_spec, oe_, oe_offsets_begin_, oe_offsets_end_,
- oe_splitters_);
+ oe_splitters_);
for (auto& vec : oe_splitters_) {
ie_splitters_ptr_.push_back(vec.data());
oe_splitters_ptr_.push_back(vec.data()); with changes manually applieddiff --git a/analytical_engine/core/fragment/arrow_projected_fragment.h b/analytical_engine/core/fragment/arrow_projected_fragment.h
index 36115e78..dea39672 100644
--- a/analytical_engine/core/fragment/arrow_projected_fragment.h
+++ b/analytical_engine/core/fragment/arrow_projected_fragment.h
@@ -1141,9 +1141,9 @@ class ArrowProjectedFragment
oe_splitters_ptr_.clear();
if (directed_) {
initEdgeSplitters(comm_spec, ie_, ie_offsets_begin_, ie_offsets_end_,
- ie_splitters_);
+ ie_splitters_);
initEdgeSplitters(comm_spec, oe_, oe_offsets_begin_, oe_offsets_end_,
- oe_splitters_);
+ oe_splitters_);
for (auto& vec : ie_splitters_) {
ie_splitters_ptr_.push_back(vec.data());
}
@@ -1152,7 +1152,7 @@ class ArrowProjectedFragment
}
} else {
initEdgeSplitters(comm_spec, oe_, oe_offsets_begin_, oe_offsets_end_,
- oe_splitters_);
+ oe_splitters_);
for (auto& vec : oe_splitters_) {
ie_splitters_ptr_.push_back(vec.data());
oe_splitters_ptr_.push_back(vec.data()); |
f0ceb36
to
d734519
Compare
What do these changes do?
Fixes spelling errors in comments per #3547 (comment)
Related issue number