Add a local deploy and test ci on MacOS #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighingnow
reviewed
Jul 12, 2021
sighingnow
reviewed
Jul 12, 2021
yecol
reviewed
Jul 13, 2021
yecol
requested changes
Jul 13, 2021
sighingnow
reviewed
Jul 14, 2021
sighingnow
reviewed
Jul 14, 2021
| run: | | ||
| export PATH=/usr/local/opt/gnu-sed/libexec/gnubin:${JAVA_HOME}/bin:${PATH}:/usr/local/zookeeper/bin | ||
|
|
||
| make gae gie |
There was a problem hiding this comment.
We won't enable GLE in this pull request, right?
sighingnow
reviewed
Jul 14, 2021
| return first.map(|s| s.to_string()).unwrap_or("127.0.0.1".to_string()); | ||
| } else { | ||
| // Mac can only deploy on local. | ||
| return String::from("127.0.0.1"); |
There was a problem hiding this comment.
Why hostname -I doesn't work here?
There was a problem hiding this comment.
hostname command no option -I in MacOS
sighingnow
reviewed
Jul 14, 2021
acezen
changed the title
acezen
changed the title
|
The pull requests is ready, any comments? |
sighingnow
approved these changes
Jul 15, 2021
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add a ci on MacOS
Related issue number
Fixes #479