[GAIA] Add storage adapter for graphscope store #521

BingqingLyu · 2021-07-13T02:54:41Z

What do these changes do?

Add adapter for querying GraphScope store in GAIA.
Add MultiPartition to route the vid/eid query request to the partition that holds its data and assign an worker to do the query.
Fix compile error with dependency on GraphScope store.

Related issue number

Fixes #417

research/gaia/gremlin/gs_gremlin/Cargo.toml

yecol · 2021-07-13T03:22:44Z

interactive_engine/src/executor/store/Cargo.toml

@@ -26,6 +26,7 @@ maxgraph-common = { path = "../../common/rust/common" }

 [dependencies.rocksdb]
 git = "https://github.com/pingcap/rust-rocksdb.git"
+rev = "23a604459899f4f7a4c8967f16b6fa623474f27b"


can we depend on a general/stable verison?

This is a historical issue: the MaxGraph storage has depended on this wired version. While it is necessary to migrate to a stable version, I think we can do that by creating another issue.

Sure, created as issue #525

longbinlai · 2021-07-13T03:37:13Z

research/gaia/gremlin/gs_gremlin/src/graph_proxy/global_storage.rs

+                None,
+                prop_ids.as_ref(),
+                params.limit.unwrap_or(0),
+                // TODO(bingqing): optimization here, each worker may scan some partitions on current server; We use worker 0 to scan all partitions for now


Comments too loooong, make it two/more lines.

These apply to the following functions

longbinlai · 2021-07-13T03:41:02Z

research/gaia/gremlin/gs_gremlin/src/graph_proxy/global_storage.rs

+                None,
+                None,
+                prop_ids.as_ref(),
+                params.limit.unwrap_or(0),


Does zero limit mean no limit? Better comment this.

Yes, and I added the comment

longbinlai · 2021-07-13T03:41:44Z

research/gaia/gremlin/gs_gremlin/src/graph_proxy/global_storage.rs

+            .get_all_vertices(
+                si,
+                label_ids.as_ref(),
+                None,


Can common these two None to increase readability.

longbinlai · 2021-07-13T05:54:38Z

research/gaia/gremlin/gs_gremlin/src/graph_proxy/global_storage.rs

+                // Zero limit means no limit. Same as follows.
+                params.limit.unwrap_or(0),
+                // TODO(bingqing): optimization, each worker may scan some partitions on current server.
+                // Empty vector means all partitions, since we use worker 0 to scan all for now.


The comment looks strange to me. worker 0 for now? Why? What is your future plan?

We assign workers to scan partitions in source operator, and for now, worker 0 (specifically, the first worker on each server) is going to scan all partitions on current server for correctness guarantee. In the future, source op should assign each worker to scan some partitions, i.e., allow parallel scan.

BTW, I didn't do this optimization since V2 store and vineyard store seems to give the info of "which worker should scan which partitions" in a ununified way. I will do this optimization after adapting to vineyard.

longbinlai · 2021-07-13T06:18:41Z

research/gaia/gremlin/gs_gremlin/src/graph_proxy/global_storage.rs

+            .ok_or(str_to_dyn_error("get schema failed"))?;
+        let edge_label_ids = encode_storage_label(params.labels.as_ref(), schema.clone());
+
+        let stmt = from_fn(move |v: ID| {


My concern: calling build_partition_vertex_ids for each vertex may not be a good idea, where build_partition_vertex_ids is for a bulk of vertices and will have to new a hashmap each time. This is too heavy for processing a single vertex. Can have better design! This applies to the following codes.

Totally agree. However, GlobalGraphQuery trait defined in GraphScope is designed to process a bulk of vertices, while in GAIA, the bulk process is actually in engine, and adapter is only able to process a single vertex each time.
In the new commit, I remove the unnecessary new HashMap in build_partition_vertex_ids function.

longbinlai · 2021-07-13T06:33:47Z

research/gaia/gremlin/gs_gremlin/src/graph_proxy/mod.rs

+        let server_index = self
+            .graph_partition_manager
+            .get_server_id(partition_id as PropId)
+            .unwrap_or_else(|| {


Looks like get_partition should return Result. This error is very critical, should not just return 0 directly, but throwing out the error instead.

longbinlai · 2021-07-13T06:36:26Z

research/gaia/gremlin/gs_gremlin/src/graph_proxy/util.rs

@@ -0,0 +1,74 @@
+//


Have no idea why you cannot directly import these functions from Gaia. You can import it into somewhere in graph_proxy for internal use. If it is private in Gaia, make it public is okay.

longbinlai

A critical issue is the build_partition_(label_)vertex_ids for each vertex. Be aware the costly operation in this function.

…necessary hashmap

longbinlai · 2021-07-13T09:33:59Z

research/gaia/gremlin/gs_gremlin/src/graph_proxy/global_storage.rs

@@ -446,17 +446,10 @@ fn build_partition_label_vertex_ids(
 /// Transform type of ids to PartitionVertexIds as required by graphscope store,
 /// which consists of (PartitionId,Vec<VertexId>)
 fn build_partition_vertex_ids(
-    ids: &[ID],
+    id: &ID,
    graph_partition_manager: Arc<dyn GraphPartitionManager>,
 ) -> Vec<PartitionVertexIds> {


Why not get_partition_vertex_id() -> PartitionVertexId. Also, id is better using id: ID without reference.

How about the other function with label_ids ?

I've rename the functions. And also using id: ID. For the other function with label_ids (get_partition_label_vertex_ids), since it is batch query indeed, I kept the old way.

longbinlai

[WIP] Rocksdb dependence will be refined, as issue #525 suggests.

BingqingLyu added 3 commits July 13, 2021 10:06

[WIP] fix compile error when depending on store crate

f89bdc4

[store_adapter] add adapter for graphscope storage

0df96e9

[store_adapter] add MultiPartition for graphscope storage

f132828

BingqingLyu requested a review from longbinlai July 13, 2021 02:54

minor refine the codes

f28d055

yecol reviewed Jul 13, 2021

View reviewed changes

longbinlai reviewed Jul 13, 2021

View reviewed changes

BingqingLyu added 2 commits July 13, 2021 12:07

minor refine

d552fef

longbinlai reviewed Jul 13, 2021

View reviewed changes

BingqingLyu added 3 commits July 13, 2021 14:43

[store_adapter] update build_partition_vertex_ids function, remove un…

22f646c

…necessary hashmap

import utils from gremlin_core

8f0192b

[gremlin_core] throw error in get_partition and update related codes

d237b64

yecol mentioned this pull request Jul 13, 2021

Migrate the rocks-db dependency of storage to a stable version #525

Closed

longbinlai reviewed Jul 13, 2021

View reviewed changes

minor refine

52daa03

longbinlai approved these changes Jul 14, 2021

View reviewed changes

lidongze0629 self-requested a review July 14, 2021 02:22

lidongze0629 approved these changes Jul 14, 2021

View reviewed changes

BingqingLyu merged commit 55adea9 into alibaba:main Jul 14, 2021

BingqingLyu deleted the develop_gs_store_adapter branch July 14, 2021 02:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GAIA] Add storage adapter for graphscope store #521

[GAIA] Add storage adapter for graphscope store #521

BingqingLyu commented Jul 13, 2021 •

edited

Loading

yecol Jul 13, 2021

longbinlai Jul 13, 2021

yecol Jul 13, 2021

longbinlai Jul 13, 2021 •

edited

Loading

longbinlai Jul 13, 2021

BingqingLyu Jul 13, 2021

longbinlai Jul 13, 2021 •

edited

Loading

BingqingLyu Jul 13, 2021

longbinlai Jul 13, 2021

BingqingLyu Jul 13, 2021

longbinlai Jul 13, 2021

BingqingLyu Jul 13, 2021

BingqingLyu Jul 13, 2021

longbinlai Jul 13, 2021

BingqingLyu Jul 13, 2021

longbinlai Jul 13, 2021

BingqingLyu Jul 13, 2021

longbinlai Jul 13, 2021

BingqingLyu Jul 13, 2021

longbinlai left a comment

longbinlai Jul 13, 2021

longbinlai Jul 13, 2021

BingqingLyu Jul 13, 2021

longbinlai left a comment

[GAIA] Add storage adapter for graphscope store #521

[GAIA] Add storage adapter for graphscope store #521

Conversation

BingqingLyu commented Jul 13, 2021 • edited Loading

What do these changes do?

Related issue number

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

longbinlai Jul 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

longbinlai Jul 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

longbinlai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

longbinlai left a comment

Choose a reason for hiding this comment

BingqingLyu commented Jul 13, 2021 •

edited

Loading

longbinlai Jul 13, 2021 •

edited

Loading

longbinlai Jul 13, 2021 •

edited

Loading