Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the scripts for GIE launching #581

Merged
merged 49 commits into from
Aug 6, 2021
Merged

Reorganize the scripts for GIE launching #581

merged 49 commits into from
Aug 6, 2021

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Jul 23, 2021 •
edited
Loading

What do these changes do?

  • replace distribution, deploy and instance-manager's scripts and config with interactive_engine/bin/giectl and interactive_engine/conf
  • update the launch gie command with giectl
  • unify the local's script and k8s's script with giectl.
  • also integrate max_node, maxgraph of v2, admin_tools and load_tools script into giectl

Related issue number

Fixes #518

yecol
yecol reviewed Jul 23, 2021
View reviewed changes
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
yecol
yecol requested changes Jul 27, 2021
View reviewed changes
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
interactive_engine/bin/giectl.sh Outdated Show resolved Hide resolved
@acezen acezen force-pushed the acezen/gie-script branch 3 times, most recently from bf3a408 to c410dbd Compare July 30, 2021 02:58
@acezen acezen marked this pull request as ready for review July 30, 2021 03:08
@acezen acezen changed the title [WIP] Reorganize the scripts for GIE launching Reorganize the scripts for GIE launching Jul 30, 2021
@acezen acezen requested a review from lidongze0629 July 30, 2021 03:08
@acezen acezen force-pushed the acezen/gie-script branch 2 times, most recently from 857e7dc to f95fa6a Compare August 2, 2021 02:34
@acezen acezen requested a review from shirly121 August 2, 2021 02:55
@acezen acezen force-pushed the acezen/gie-script branch 2 times, most recently from 563633f to 6e65a1c Compare August 4, 2021 07:02
yecol
yecol requested changes Aug 4, 2021
View reviewed changes
.github/workflows/graphscope.Dockerfile Outdated Show resolved Hide resolved
charts/graphscope-store/templates/frontend/statefulset.yaml Outdated Show resolved Hide resolved
charts/graphscope-store/templates/configmap.yaml Outdated Show resolved Hide resolved
@acezen
Copy link
Collaborator Author

acezen commented Aug 6, 2021

pr is ready, any comment?

@lidongze0629 lidongze0629 requested a review from yecol August 6, 2021 05:27
@lidongze0629 lidongze0629 merged commit 032ed99 into alibaba:main Aug 6, 2021
@acezen acezen deleted the acezen/gie-script branch August 6, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirly121 shirly121 shirly121 approved these changes

@lidongze0629 lidongze0629 Awaiting requested review from lidongze0629

@yecol yecol Awaiting requested review from yecol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganize the scripts for GIE launching
4 participants
@acezen @yecol @shirly121 @lidongze0629