Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zh docs for GraphScope #67

Merged
merged 37 commits into from Jan 7, 2021
Merged

add zh docs for GraphScope #67

merged 37 commits into from Jan 7, 2021

Conversation

yecol
Copy link
Collaborator

@yecol yecol commented Jan 6, 2021

What do these changes do?

add Chinese version of READMEs and docs.

Related issue number

Address #28

yecol and others added 3 commits January 6, 2021 12:12
* add benchmark zh

* finish chinese doc for benchmark

* Initial version of the Chinese docs for GIE.

* fix python

* minor

* fix typos

Co-authored-by: Zhengping Qian <zhengping.qzp@alibaba-inc.com>
* Check external-ip is null by for loop
* Skip checking instance ready when localhost.
@yecol yecol marked this pull request as draft January 7, 2021 02:31
@yecol yecol changed the title [wip] add zh docs for GraphScope add zh docs for GraphScope Jan 7, 2021
@yecol yecol marked this pull request as ready for review January 7, 2021 10:18
@yecol yecol requested a review from sighingnow January 7, 2021 10:19
@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #67 (b8a25a7) into main (5c9a222) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   78.04%   78.01%   -0.04%     
==========================================
  Files          49       49              
  Lines        4473     4475       +2     
==========================================
  Hits         3491     3491              
- Misses        982      984       +2     
Impacted Files Coverage Δ
python/graphscope/deploy/kubernetes/cluster.py 73.70% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f41ad...c376f7e. Read the comment docs.

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@sighingnow sighingnow merged commit 53636b2 into alibaba:main Jan 7, 2021
@yecol yecol deleted the docs branch January 8, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants