Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the legacy code related to graph manager and make default user 'graphscope' in graphscope-store image #748

Merged
merged 4 commits into from
Sep 1, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,7 @@ jobs:
- name: Clean
if: always()
run: |
sudo docker rmi -f registry.cn-hongkong.aliyuncs.com/graphscope/graphscope:${{ github.sha }} \
registry.cn-hongkong.aliyuncs.com/graphscope/maxgraph_standalone_manager:${{ github.sha }} || true
sudo docker rmi -f registry.cn-hongkong.aliyuncs.com/graphscope/graphscope:${{ github.sha }} || true
helm uninstall graphscope || true
kubectl delete pod graphscope-test-rpc-service --wait=false || true

Expand Down Expand Up @@ -519,9 +518,6 @@ jobs:
echo "source ~/.cargo/env" >> ~/.bashrc
source ~/.bashrc
rustup component add rustfmt
sudo yum update -y
sudo yum install -y xz
sudo ln -s /bin/true /bin/apt-get

- uses: actions/checkout@v2.3.2

Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/docker_nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ jobs:
cd ${GITHUB_WORKSPACE}
sudo make graphscope

- name: Build interactive_manager image
run: |
cd ${GITHUB_WORKSPACE}
sudo make interactive_manager

- name: Build graphscope-store image
run: |
cd ${GITHUB_WORKSPACE}
Expand All @@ -32,7 +27,6 @@ jobs:
short_sha=$(git rev-parse --short HEAD)
echo "SHORT_SHA=${short_sha}" >> $GITHUB_ENV
echo "GS_IMAGE=graphscope/graphscope:${short_sha}" >> $GITHUB_ENV
echo "GIE_MANAGER_IMAGE=graphscope/maxgraph_standalone_manager:${short_sha}" >> $GITHUB_ENV

- name: Kubernetes test
env:
Expand All @@ -53,21 +47,16 @@ jobs:
echo ${{ secrets.ALIYUN_TOKEN }} | sudo docker login --username=grape_dev registry.cn-hongkong.aliyuncs.com --password-stdin
sudo docker tag graphscope/graphscope:${SHORT_SHA} \
registry.cn-hongkong.aliyuncs.com/graphscope/graphscope:nightly
sudo docker tag graphscope/maxgraph_standalone_manager:${SHORT_SHA} \
registry.cn-hongkong.aliyuncs.com/graphscope/maxgraph_standalone_manager:nightly
sudo docker tag graphscope/graphscope-store:${SHORT_SHA} \
registry.cn-hongkong.aliyuncs.com/graphscope/graphscope-store:nightly

sudo docker push registry.cn-hongkong.aliyuncs.com/graphscope/graphscope:nightly
sudo docker push registry.cn-hongkong.aliyuncs.com/graphscope/maxgraph_standalone_manager:nightly
sudo docker push registry.cn-hongkong.aliyuncs.com/graphscope/graphscope-store:nightly

- name: Clean
if: always()
run: |
sudo docker rmi -f graphscope/graphscope:${SHORT_SHA} \
graphscope/maxgraph_standalone_manager:${SHORT_SHA} \
graphscope/graphscope-store:${SHORT_SHA} \
registry.cn-hongkong.aliyuncs.com/graphscope/graphscope:nightly \
registry.cn-hongkong.aliyuncs.com/graphscope/maxgraph_standalone_manager:nightly \
registry.cn-hongkong.aliyuncs.com/graphscope/graphscope-store:nightly || true
14 changes: 5 additions & 9 deletions .github/workflows/graphscope-store.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
FROM registry.cn-hongkong.aliyuncs.com/graphscope/graphscope-runtime:latest-root-user
FROM registry.cn-hongkong.aliyuncs.com/graphscope/graphscope-runtime:latest

RUN mkdir -p /home/maxgraph/{bin,conf}
COPY ./opt/graphscope/ /usr/local/
COPY ./maxgraph /home/maxgraph/maxgraph
COPY ./maxgraph /usr/local/maxgraph
COPY ./ready_probe.sh /tmp/ready_probe.sh
COPY ./interactive_engine/bin/giectl /home/maxgraph/bin/giectl
COPY ./interactive_engine/conf/* /home/maxgraph/conf/
COPY ./interactive_engine/bin/giectl /usr/local/bin/giectl
COPY ./interactive_engine/conf/* /usr/local/conf/

ENV GRAPHSCOPE_HOME=/home/maxgraph
ENV GRAPHSCOPE_RUNTIME=/tmp/graphscope

WORKDIR /home/maxgraph/
ENV GRAPHSCOPE_HOME=/usr/local
5 changes: 2 additions & 3 deletions README-zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,7 @@ GraphScope 包含一个 [Dockerfile](k8s/graphscope.Dockerfile),可以构建 D
# ./scripts/prepare_dev.sh

make graphscope
make interactive_manager
# by default, the built image is tagged as graphscope/graphscope:SHORTSHA and graphscope/maxgraph_standalone_manager:SHORTSHA
# by default, the built image is tagged as graphscope/graphscope:SHORTSHA
```

### 构建客户端 Python 包
Expand Down Expand Up @@ -351,7 +350,7 @@ python3 setup.py install
./scripts/test.sh --all

# run all test cases on your built image
./scripts/test.sh --all --gs_image graphscope/graphscope:SHORTSHA --gie_manager_image graphscope/maxgraph_standalone_manager:SHORTSHA
./scripts/test.sh --all --gs_image graphscope/graphscope:SHORTSHA

# or run the selected cases on a certain module. e.g.,
./scripts/test.sh --python
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,7 @@ a `runtime-base` image. To build images with latest version of GraphScope, go to
# ./scripts/prepare_dev.sh

make graphscope
make interactive_manager
# by default, the built image is tagged as graphscope/graphscope:SHORTSHA and graphscope/maxgraph_standalone_manager:SHORTSHA
# by default, the built image is tagged as graphscope/graphscope:SHORTSHA
```

### Building client library
Expand Down Expand Up @@ -364,7 +363,7 @@ You may run the whole test suite with commands:
./scripts/test.sh --all

# run all test cases on your built image
./scripts/test.sh --all --gs_image graphscope/graphscope:SHORTSHA --gie_manager_image graphscope/maxgraph_standalone_manager:SHORTSHA
./scripts/test.sh --all --gs_image graphscope/graphscope:SHORTSHA

# or run the selected cases on a certain module. e.g.,
./scripts/test.sh --python
Expand Down
20 changes: 10 additions & 10 deletions charts/graphscope-store/templates/coordinator/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,16 @@ spec:

[[ `hostname` =~ -([0-9]+)$ ]] || exit 1
ordinal=${BASH_REMATCH[1]}
sed -e "s/ROLE/$(ROLE)/g" \
-e "s/INDEX/${ordinal}/g" \
-e "s/KAFKA_SERVERS/$(KAFKA_SERVERS)/g" \
-e "s/FRONTEND/$(DNS_NAME_PREFIX_FRONTEND)/g" \
-e "s/INGESTOR/$(DNS_NAME_PREFIX_INGESTOR)/g" \
-e "s/COORDINATOR/$(DNS_NAME_PREFIX_COORDINATOR)/g" \
-e "s/STORE/$(DNS_NAME_PREFIX_STORE)/g" \
-e "s@LOG4RS_CONFIG@${GRAPHSCOPE_HOME}/conf/log4rs.yml@g" \
/etc/graphscope-store/my.cnf.tpl > /etc/graphscope-store/my.cnf
LOG_NAME=graphscope-store.log /home/maxgraph/bin/giectl maxgraph /etc/graphscope-store/my.cnf coordinator
sudo sed -e "s/ROLE/$(ROLE)/g" \
-e "s/INDEX/${ordinal}/g" \
-e "s/KAFKA_SERVERS/$(KAFKA_SERVERS)/g" \
-e "s/FRONTEND/$(DNS_NAME_PREFIX_FRONTEND)/g" \
-e "s/INGESTOR/$(DNS_NAME_PREFIX_INGESTOR)/g" \
-e "s/COORDINATOR/$(DNS_NAME_PREFIX_COORDINATOR)/g" \
-e "s/STORE/$(DNS_NAME_PREFIX_STORE)/g" \
-e "s@LOG4RS_CONFIG@${GRAPHSCOPE_HOME}/conf/log4rs.yml@g" \
/etc/graphscope-store/my.cnf.tpl | sudo tee /etc/graphscope-store/my.cnf
LOG_NAME=graphscope-store.log ${GRAPHSCOPE_HOME}/bin/giectl maxgraph /etc/graphscope-store/my.cnf coordinator
Copy link
Collaborator

@acezen acezen Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphscope-store is an independent package, so we don't use GRAPHSCOPE_HOME in graphscope-store.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. instead of /usr/local

tail -f /dev/null
env:
- name: DEBUG
Expand Down
22 changes: 11 additions & 11 deletions charts/graphscope-store/templates/frontend/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,18 @@ spec:

[[ `hostname` =~ -([0-9]+)$ ]] || exit 1
ordinal=${BASH_REMATCH[1]}
sed -e "s/GRAPH_NAME/$(GRAPH_NAME)/g" \
-e "s/ROLE/$(ROLE)/g" \
-e "s/INDEX/${ordinal}/g" \
-e "s/KAFKA_SERVERS/$(KAFKA_SERVERS)/g" \
-e "s/FRONTEND/$(DNS_NAME_PREFIX_FRONTEND)/g" \
-e "s/INGESTOR/$(DNS_NAME_PREFIX_INGESTOR)/g" \
-e "s/COORDINATOR/$(DNS_NAME_PREFIX_COORDINATOR)/g" \
-e "s/STORE/$(DNS_NAME_PREFIX_STORE)/g" \
-e "s@LOG4RS_CONFIG@${GRAPHSCOPE_HOME}/conf/log4rs.yml@g" \
/etc/graphscope-store/my.cnf.tpl > /etc/graphscope-store/my.cnf
sudo sed -e "s/GRAPH_NAME/$(GRAPH_NAME)/g" \
-e "s/ROLE/$(ROLE)/g" \
-e "s/INDEX/${ordinal}/g" \
-e "s/KAFKA_SERVERS/$(KAFKA_SERVERS)/g" \
-e "s/FRONTEND/$(DNS_NAME_PREFIX_FRONTEND)/g" \
-e "s/INGESTOR/$(DNS_NAME_PREFIX_INGESTOR)/g" \
-e "s/COORDINATOR/$(DNS_NAME_PREFIX_COORDINATOR)/g" \
-e "s/STORE/$(DNS_NAME_PREFIX_STORE)/g" \
-e "s@LOG4RS_CONFIG@${GRAPHSCOPE_HOME}/conf/log4rs.yml@g" \
/etc/graphscope-store/my.cnf.tpl | sudo tee /etc/graphscope-store/my.cnf

LOG_NAME=graphscope-store.log /home/maxgraph/bin/giectl maxgraph /etc/graphscope-store/my.cnf $(EXECUTOR)
LOG_NAME=graphscope-store.log ${GRAPHSCOPE_HOME}/bin/giectl maxgraph /etc/graphscope-store/my.cnf $(EXECUTOR)
tail -f /dev/null
env:
- name: DEBUG
Expand Down
22 changes: 11 additions & 11 deletions charts/graphscope-store/templates/ingestor/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,18 @@ spec:

[[ `hostname` =~ -([0-9]+)$ ]] || exit 1
ordinal=${BASH_REMATCH[1]}
sed -e "s/GRAPH_NAME/$(GRAPH_NAME)/g" \
-e "s/ROLE/$(ROLE)/g" \
-e "s/INDEX/${ordinal}/g" \
-e "s/KAFKA_SERVERS/$(KAFKA_SERVERS)/g" \
-e "s/FRONTEND/$(DNS_NAME_PREFIX_FRONTEND)/g" \
-e "s/INGESTOR/$(DNS_NAME_PREFIX_INGESTOR)/g" \
-e "s/COORDINATOR/$(DNS_NAME_PREFIX_COORDINATOR)/g" \
-e "s/STORE/$(DNS_NAME_PREFIX_STORE)/g" \
-e "s@LOG4RS_CONFIG@${GRAPHSCOPE_HOME}/conf/log4rs.yml@g" \
/etc/graphscope-store/my.cnf.tpl > /etc/graphscope-store/my.cnf
sudo sed -e "s/GRAPH_NAME/$(GRAPH_NAME)/g" \
-e "s/ROLE/$(ROLE)/g" \
-e "s/INDEX/${ordinal}/g" \
-e "s/KAFKA_SERVERS/$(KAFKA_SERVERS)/g" \
-e "s/FRONTEND/$(DNS_NAME_PREFIX_FRONTEND)/g" \
-e "s/INGESTOR/$(DNS_NAME_PREFIX_INGESTOR)/g" \
-e "s/COORDINATOR/$(DNS_NAME_PREFIX_COORDINATOR)/g" \
-e "s/STORE/$(DNS_NAME_PREFIX_STORE)/g" \
-e "s@LOG4RS_CONFIG@${GRAPHSCOPE_HOME}/conf/log4rs.yml@g" \
/etc/graphscope-store/my.cnf.tpl | sudo tee /etc/graphscope-store/my.cnf

LOG_NAME=graphscope-store.log /home/maxgraph/bin/giectl maxgraph /etc/graphscope-store/my.cnf ingestor
LOG_NAME=graphscope-store.log ${GRAPHSCOPE_HOME}/bin/giectl maxgraph /etc/graphscope-store/my.cnf ingestor
tail -f /dev/null
env:
- name: DEBUG
Expand Down
22 changes: 11 additions & 11 deletions charts/graphscope-store/templates/store/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,18 @@ spec:

[[ `hostname` =~ -([0-9]+)$ ]] || exit 1
ordinal=${BASH_REMATCH[1]}
sed -e "s/GRAPH_NAME/$(GRAPH_NAME)/g" \
-e "s/ROLE/$(ROLE)/g" \
-e "s/INDEX/${ordinal}/g" \
-e "s/KAFKA_SERVERS/$(KAFKA_SERVERS)/g" \
-e "s/FRONTEND/$(DNS_NAME_PREFIX_FRONTEND)/g" \
-e "s/INGESTOR/$(DNS_NAME_PREFIX_INGESTOR)/g" \
-e "s/COORDINATOR/$(DNS_NAME_PREFIX_COORDINATOR)/g" \
-e "s/STORE/$(DNS_NAME_PREFIX_STORE)/g" \
-e "s@LOG4RS_CONFIG@${GRAPHSCOPE_HOME}/conf/log4rs.yml@g" \
/etc/graphscope-store/my.cnf.tpl > /etc/graphscope-store/my.cnf
sudo sed -e "s/GRAPH_NAME/$(GRAPH_NAME)/g" \
-e "s/ROLE/$(ROLE)/g" \
-e "s/INDEX/${ordinal}/g" \
-e "s/KAFKA_SERVERS/$(KAFKA_SERVERS)/g" \
-e "s/FRONTEND/$(DNS_NAME_PREFIX_FRONTEND)/g" \
-e "s/INGESTOR/$(DNS_NAME_PREFIX_INGESTOR)/g" \
-e "s/COORDINATOR/$(DNS_NAME_PREFIX_COORDINATOR)/g" \
-e "s/STORE/$(DNS_NAME_PREFIX_STORE)/g" \
-e "s@LOG4RS_CONFIG@${GRAPHSCOPE_HOME}/conf/log4rs.yml@g" \
/etc/graphscope-store/my.cnf.tpl | sudo tee /etc/graphscope-store/my.cnf

LOG_NAME=graphscope-store.log /home/maxgraph/bin/giectl maxgraph /etc/graphscope-store/my.cnf $(EXECUTOR)
LOG_NAME=graphscope-store.log ${GRAPHSCOPE_HOME}/bin/giectl maxgraph /etc/graphscope-store/my.cnf $(EXECUTOR)
tail -f /dev/null
env:
- name: DEBUG
Expand Down
Loading