Remove the legacy code related to graph manager and make default user 'graphscope' in graphscope-store image #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidongze0629
requested review from
acezen,
siyuan0322,
sighingnow,
yecol and
tianliplus
sighingnow
approved these changes
Sep 1, 2021
|
Could we rename the PR? The major part has nothing to do with the non-root user issue.. |
acezen
reviewed
Sep 1, 2021
| -e "s/STORE/$(DNS_NAME_PREFIX_STORE)/g" \ | ||
| -e "s@LOG4RS_CONFIG@${GRAPHSCOPE_HOME}/conf/log4rs.yml@g" \ | ||
| /etc/graphscope-store/my.cnf.tpl | sudo tee /etc/graphscope-store/my.cnf | ||
| LOG_NAME=graphscope-store.log ${GRAPHSCOPE_HOME}/bin/giectl maxgraph /etc/graphscope-store/my.cnf coordinator |
There was a problem hiding this comment.
graphscope-store is an independent package, so we don't use GRAPHSCOPE_HOME in graphscope-store.
There was a problem hiding this comment.
done. instead of /usr/local
lidongze0629
changed the title
lidongze0629
changed the title
lidongze0629
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes