clear duplicated and unused code #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 海虾 <tianli.tl@alibaba-inc.com>
1. Update edge id from string to bytes in pb
2. Use edge inner id for v2 and vineyard as edge ID in gaia runtime
3. Convert edge id into i64 from bytes for v2 in compiler
4. Change permission of ${GITHUB_WORKSPACE} as the remnants of build-gss cannot be deleted
Co-authored-by: BingqingLyu <lv_bingqing@163.com>
Co-authored-by: siyuan0322 <siyuan0322@gmail.com>
* Integrate GraphManager into Coordinator * Do not create a pod during `sess.gremlin` * Avoid using root user in docker image * Unify GRAPHSCOPE_HOME prefix
yecol
approved these changes
Sep 7, 2021
siyuan0322
reviewed
Sep 7, 2021
siyuan0322
reviewed
Sep 8, 2021
.github/workflows/ci.yml
Outdated
| @@ -592,6 +593,7 @@ jobs: | |||
| name: gss-${{ github.sha }} | |||
| path: | | |||
| maxgraph.tar.gz | |||
| graphscope_store_data_load.tar.gz | |||
There was a problem hiding this comment.
It would be better to add another upload-artifact step to only load the graphscope_store_data_load.tar.gz, or else it will be package together with maxgraph.tar.gz which has a much larger size, It will be convenient for us to be able to download this artifact only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes #536