Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard的ReadMe描述不准确 #117

Closed
pengminxuan opened this issue Sep 2, 2018 · 3 comments
Closed

dashboard的ReadMe描述不准确 #117

pengminxuan opened this issue Sep 2, 2018 · 3 comments
Labels
area/document Category issues or prs related to document.

Comments

@pengminxuan
Copy link

Issue Description

Type: bug report

Describe what happened (or what feature you want)

dashboard的ReadMe中没有提到sentinel客户端连接dashboard是懒加载,看完以为是启动之后就会直接连上dashboard.

Describe what you expected to happen

修改ReadMe关于Sentinel客户端接入dashboard的相关文字

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?
@sczyh30
Copy link
Member

sczyh30 commented Sep 2, 2018

Thanks for reporting! Dashboard 的文档中已有相关说明，见此处。已加粗表强调。

@sczyh30 sczyh30 added the area/document Category issues or prs related to document. label Sep 2, 2018
@pengminxuan
Copy link
Author

但是ReadMe和wiki文档不一致的话,使用者可能也无法确认应该遵循哪个.建议修改ReadMe中的相关描述

@sczyh30
Copy link
Member

sczyh30 commented Sep 3, 2018

We'll update the README of the Dashboard soon.

@sczyh30 sczyh30 closed this as completed in f70ab5a Sep 3, 2018
sczyh30 added a commit that referenced this issue Sep 19, 2018
@sczyh30
Fixes #117: Update document of Sentinel Dashboard
897661f 
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Arlmls pushed a commit to Arlmls/Sentinel that referenced this issue Jan 8, 2019
@sczyh30
Fixes alibaba#117: Update document of Sentinel Dashboard
213bd42 
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
CST11021 pushed a commit to CST11021/Sentinel that referenced this issue Nov 3, 2021
@dongeforever
Close no response PRs, closes alibaba#164, closes alibaba#167, closes a…
a4ada22 
…libaba#166, closes alibaba#20, closes alibaba#38, closes alibaba#40, closes alibaba#57, closes alibaba#81, closes alibaba#99, closes alibaba#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/document Category issues or prs related to document.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sczyh30 @pengminxuan