Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复search.maven.org跳转问题 #57

Closed
wants to merge 1 commit into from
Closed

Conversation

Ivan97
Copy link

@Ivan97 Ivan97 commented Aug 10, 2018

Describe what this PR does / why we need it

search.maven.org更新了搜索API

Does this pull request fix one issue?

Describe how you did it

使用新的搜索API

Describe how to verify it

点击maven-badge图标即可

Special notes for reviews

修复search.maven.org跳转问题
@codecov-io
Copy link

Codecov Report

Merging #57 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
+ Coverage     45.95%   46.03%   +0.07%     
- Complexity      556      557       +1     
============================================
  Files           113      113              
  Lines          3804     3804              
  Branches        530      530              
============================================
+ Hits           1748     1751       +3     
+ Misses         1842     1840       -2     
+ Partials        214      213       -1
Impacted Files Coverage Δ Complexity Δ
...ntinel/slots/statistic/metric/WindowLeapArray.java 80% <0%> (+12%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42a930...35b3812. Read the comment docs.

@@ -3,7 +3,7 @@
# Sentinel: Sentinel of Your Application

[![Travis Build Status](https://travis-ci.org/alibaba/Sentinel.svg?branch=master)](https://travis-ci.org/alibaba/Sentinel)
[![Maven Central](https://img.shields.io/maven-central/v/com.alibaba.csp/sentinel-core.svg?label=Maven%20Central)](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22com.alibaba.csp%22%20a%3A%22sentinel-core%22)
[![Maven Central](https://img.shields.io/maven-central/v/com.alibaba.csp/sentinel-core.svg?label=Maven%20Central)](https://search.maven.org/classic/#search%7Cga%7C1%7Cg%3A%22com.alibaba.csp%22%20a%3A%22sentinel-core%22)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you may fix with https://search.maven.org/search?q=g:com.alibaba.csp%20AND%20a:sentinel-core instead of the classic one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course,thanks.In fact, I started a project to deal with maven badges.Check it out if you are interested in it.
https://github.com/Ivan97/maven-badges-generator

Copy link
Member

@sczyh30 sczyh30 Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. In fact, search.maven.org can generate Maven Central Badge markdown in the detail page (our badge was generated from there), but there are something wrong in its generated URL.

@Ivan97 Ivan97 closed this Aug 11, 2018
@Ivan97 Ivan97 deleted the patch-2 branch August 11, 2018 15:23
sczyh30 added a commit that referenced this pull request Aug 12, 2018
sczyh30 added a commit that referenced this pull request Sep 19, 2018
- Related to #57

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants