Add warm up + rate limiter flow control behavior and test cases #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
pushed a commit
that referenced
this pull request
Dec 25, 2018
) - Add a new kind of control behavior `warm up + rate limiter`, behaving as both warm up and pace control (cherry picked from commit 08f2a71)
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
…libaba#220) - Add a new kind of control behavior `warm up + rate limiter`, behaving as both warm up and pace control
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
[ROCKETMQ-332] MappedFileQueue#findMappedFileByOffset is not thread safe, which will cause message loss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Now the are three kinds of
FlowRule.controlBehavior, warm up and rate limiter are both provided, but there is no control behavior for warm up + rate limiter.Does this pull request fix one issue?
Fixes #206
Describe how you did it
Add a new kind of
FlowRule.controlBehaviorwarm up + rate limiter, behaving as both warm up and pace control. When use this control behavior, real passed qps will gradually increase to the threshold, other than burst increasing, and after the passed qps reaches the threshold, the request will pass at a constant interval.Describe how to verify it
Run test cases and demo.
Special notes for reviews
None