[feature] Expose jmx endpoint for sentinel. #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/brothelul/Sentinel into feature-alibaba#1848 � Conflicts: � sentinel-core/src/main/java/com/alibaba/csp/sentinel/slots/block/flow/FlowRuleManager.java
sczyh30
added
kind/feature
|
Hi, any progress on this PR? |
|
It looks like there have no one review it. |
I'll take a review these days. cc @jasonjoo2010 @cdfive |
|
thanks |
jasonjoo2010
requested changes
Sep 7, 2021
...ic-exporter/src/main/java/com/alibaba/csp/sentinel/metric/exporter/jmx/MetricBeanWriter.java
Outdated
Show resolved
Hide resolved
...l-metric-exporter/src/main/java/com/alibaba/csp/sentinel/metric/exporter/jmx/MetricBean.java
Show resolved
Hide resolved
...etric-exporter/src/main/java/com/alibaba/csp/sentinel/metric/exporter/jmx/MBeanRegistry.java
Show resolved
Hide resolved
sentinel-core/src/main/java/com/alibaba/csp/sentinel/slots/block/flow/FlowRuleManager.java
Outdated
Show resolved
Hide resolved
...ntinel-metric-exporter/src/main/java/com/alibaba/csp/sentinel/metric/MetricExporterInit.java
Outdated
Show resolved
Hide resolved
...metric-exporter/src/main/java/com/alibaba/csp/sentinel/metric/collector/MetricCollector.java
Outdated
Show resolved
Hide resolved
jasonjoo2010
approved these changes
Sep 14, 2021
|
Great. Thanks for contributing! 🎉 |
Zhang-0952
pushed a commit
to Zhang-0952/Sentinel
that referenced
this pull request
Mar 4, 2022
…libaba#2275) * Expose the MetricItem AS MBean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
The new implement of JMX export after we discussed. old implement please refer #1947
the JMX data like below:
Does this pull request fix one issue?
Fixes #1814
Describe how you did it
Describe how to verify it
Special notes for reviews