fix save command history npe, improve load/save history logic #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个 commit没从根本解决问题，本质原因是HistoryManagerImpl 不是线程安全的。 |
hengyunabc
reviewed
Feb 23, 2021
| @@ -481,6 +482,9 @@ public void destroy() { | |||
| sessionManager.close(); | |||
| sessionManager = null; | |||
| } | |||
| if (historyManager != null) { | |||
There was a problem hiding this comment.
这里有问题，会把原来 termd里保存的 history清空了。
如果用户没用过http api，则这里保存的历史还是arthas启动时原来的那一份。
本质上是history有两份存储了。目前应该忽略http api里的那一份。
There was a problem hiding this comment.
目前每个shell 的cmd history都是单独维护的，不同telnet session相互也会覆盖history。
http api则是用同一份history，与shell的history相互覆盖，已修改为不持久化http api的history。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.