Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #5

Closed
oraluben opened this issue Apr 2, 2022 · 0 comments · Fixed by #28
Closed

Windows support #5

oraluben opened this issue Apr 2, 2022 · 0 comments · Fixed by #28
Projects
The Board

Comments

@oraluben
Copy link
Collaborator

oraluben commented Apr 2, 2022

The current implementation uses POSIX's mmap and works on Linux and MacOS. It should be trivial to add windows support by using Windows' equivalent of mmap, e.g. MapViewOfFile.
@oraluben oraluben created this issue from a note in The Board (To do) Apr 2, 2022
@oraluben oraluben mentioned this issue Nov 23, 2022
Merged
The Board automation moved this from To do to Done Oct 18, 2023
oraluben added a commit that referenced this issue Oct 18, 2023
@oraluben
[Feature] Windows support (#28)
741ab91 
Summary: Windows support

Test Plan: All tests on Windows, Linux and Darwin

Reviewed-by: -

Issue: closes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
The Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] Windows support oraluben/pycds
1 participant
@oraluben